Skip to content

add patch to fix bug in unittest-xml-reporting on Python 3.11+#22787

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20250423094329_new_pr_unittest-xml-reporting310
May 23, 2025
Merged

add patch to fix bug in unittest-xml-reporting on Python 3.11+#22787
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20250423094329_new_pr_unittest-xml-reporting310

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Apr 23, 2025 •
edited
Loading

(created using eb --new-pr)

During a test on foss/2024a I've seen

File "/lib/python3.12/unittest/runner.py", line 152, in printErrors
self.stream.writeln(f"UNEXPECTED SUCCESS: {self.getDescription(test)}")
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/lib/python3.12/unittest/runner.py", line 50, in getDescription
doc_first_line = test.shortDescription()
^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'tuple' object has no attribute 'shortDescription'

This will be fixed by xmlrunner/unittest-xml-reporting#274 which is not yet merged but looks correct. So I just picked that commit to avoid this in our Python 3.11/3.12 EasyConfigs

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Apr 23, 2025

Test report by @Flamefire
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
login3.barnard.hpc.tu-dresden.de - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/3113368a57e62c741effe3073c81ae45 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Apr 23, 2025

Test report by @Flamefire
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
login1.romeo.hpc.tu-dresden.de - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/8764b50efbf3cc0cd303f50536431856 for a full test report.

@boegel boegel added bug fix and removed change labels Apr 23, 2025
@boegel boegel added this to the release after 5.0.0 milestone Apr 23, 2025
@boegel boegel changed the title Fix bug in unittest-xml-reporting on Python 3.11+ add patch to fix bug in unittest-xml-reporting on Python 3.11+ May 23, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented May 23, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 23, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22787 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22787 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6469

Test results coming soon (I hope)...

Details

- notification for comment with ID 2905878448 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented May 23, 2025

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3539.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/677e78af28561af9f64d6b36109f58f5 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 23, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/803292c42a95d641bf8d339cf60b8462 for a full test report.

boegel
boegel approved these changes May 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 23, 2025

Going in, thanks @Flamefire!

@boegel boegel merged commit 1ff3550 into easybuilders:develop May 23, 2025
8 checks passed
@Flamefire Flamefire deleted the 20250423094329_new_pr_unittest-xml-reporting310 branch May 24, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @boegel @boegelbot