Skip to content

set C standard to c99 for ncurses 6.5 with system toolchain#22807

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
Thyre:20250425153839_new_pr_ncurses65
Apr 25, 2025
Merged

set C standard to c99 for ncurses 6.5 with system toolchain#22807
jfgrimm merged 1 commit intoeasybuilders:developfrom
Thyre:20250425153839_new_pr_ncurses65

Conversation

@Thyre
Copy link
Copy Markdown
Collaborator

@Thyre Thyre commented Apr 25, 2025 •
edited
Loading

(created using eb --new-pr)

Prevents build failure with GCC 15, due to changes in stdbool.h and bool

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Apr 25, 2025 •
edited
Loading

Test report by @Thyre
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x AMD Navi 48 [RX 9070/9070 XT] (device id: 0x7550, gfx: gfx1201, driver: 6.14.3-arch1-1), 1 x AMD Raphael (device id: 0x164e, gfx: gfx1036, driver: 6.14.3-arch1-1), Python 3.13.3
See https://gist.github.com/Thyre/479c088fa5b0bd7df1eedb0a9c3cdd36 for a full test report.

"terminfo.tmp", line 24325, terminal 'v3220': /usr/share/terminfo: permission denied (errno 13)

Huh? Maybe some environment variable was set...

TERMINFO was the culprit.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Apr 25, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
Framework - Linux Fedora Linux 42, x86_64, AMD Ryzen AI 7 350 w/ Radeon 860M, 1 x AMD Krackan [Radeon 840M / 860M Graphics] (device id: 0x1114, gfx: gfx1152, driver: 6.14.3-300.fc42.x86_64), Python 3.13.3
See https://gist.github.com/Thyre/cf05b7e41c08d68b5f9c2f484d2f87fe for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Apr 25, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x AMD Navi 48 [RX 9070/9070 XT] (device id: 0x7550, gfx: gfx1201, driver: 6.14.3-arch1-1), 1 x AMD Raphael (device id: 0x164e, gfx: gfx1036, driver: 6.14.3-arch1-1), Python 3.13.3
See https://gist.github.com/Thyre/b2d0e710a14f47150fe0fda4228fd7ca for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Apr 25, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
ZAM054 - Linux Zorin OS 17, x86_64, 12th Gen Intel(R) Core(TM) i7-1260P, 1 x NVIDIA NVIDIA GeForce MX550, 565.57.01, Python 3.10.12
See https://gist.github.com/Thyre/48a2bb6bfe4e150f448f4791643dc6d3 for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Apr 25, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 25, 2025

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22807 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22807 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6242

Test results coming soon (I hope)...

Details

- notification for comment with ID 2830485640 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 25, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/eb6272717dc6a00611b018a3a63cc3d0 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Apr 25, 2025

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node020.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/c977e6305ef2cb35376fb40898c91660 for a full test report.

jfgrimm
jfgrimm approved these changes Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm added bug fix and removed change labels Apr 25, 2025
@jfgrimm jfgrimm added this to the 5.0.1 milestone Apr 25, 2025
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Apr 25, 2025

Going in, thanks @Thyre!

@jfgrimm jfgrimm merged commit 9ffd222 into easybuilders:develop Apr 25, 2025
8 checks passed
@boegel boegel changed the title {devel}[system/system] Set C standard for ncurses 6.5 set C standard to c99 for ncurses 6.5 with system toolchain May 26, 2025
@Thyre Thyre deleted the 20250425153839_new_pr_ncurses65 branch August 10, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Thyre @boegelbot @jfgrimm