Skip to content

Use Java 21 wrapper instead of specific version for Turbovnc#22838

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
Micket:20250505093206_new_pr_TurboVNC312
May 6, 2025
Merged

Use Java 21 wrapper instead of specific version for Turbovnc#22838
jfgrimm merged 1 commit intoeasybuilders:developfrom
Micket:20250505093206_new_pr_TurboVNC312

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented May 5, 2025

(created using eb --new-pr)

@Micket Micket added the bug fix label May 5, 2025
@github-actions github-actions Bot added the change label May 5, 2025
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 5, 2025

Otherwise it will cause unwanted conflicts when Java is updated.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 5, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--module-only"

@Micket Micket added this to the release after 5.0.1 milestone May 5, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 5, 2025

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22838 EB_ARGS="--module-only" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22838 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6289

Test results coming soon (I hope)...

Details

- notification for comment with ID 2851307015 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 6, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 6, 2025

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22838 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22838 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6292

Test results coming soon (I hope)...

Details

- notification for comment with ID 2853746837 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 6, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/99a3403c62f8bc6477c9fbb6586dd096 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented May 6, 2025

Going in, thanks @Micket!

@jfgrimm jfgrimm merged commit a893dc3 into easybuilders:develop May 6, 2025
8 checks passed
@Micket Micket deleted the 20250505093206_new_pr_TurboVNC312 branch May 6, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Micket @boegelbot @jfgrimm @boegel