Skip to content

Use Java 21 wrapper instead of specific version for Bazel#22839

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
Micket:20250505093343_new_pr_Bazel741
May 6, 2025
Merged

Use Java 21 wrapper instead of specific version for Bazel#22839
jfgrimm merged 1 commit intoeasybuilders:developfrom
Micket:20250505093343_new_pr_Bazel741

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented May 5, 2025

(created using eb --new-pr)

@github-actions github-actions Bot added the change label May 5, 2025
@Micket Micket added the bug fix label May 5, 2025
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 5, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--module-only"

@Micket Micket added this to the release after 5.0.1 milestone May 5, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 5, 2025

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22839 EB_ARGS="--module-only" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22839 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6288

Test results coming soon (I hope)...

Details

- notification for comment with ID 2851307324 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 5, 2025

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/ba6ba3b406c08cacce1afd74b45f2cff for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented May 6, 2025 

== 2025-05-05 15:10:45,360 build_log.py:226 ERROR EasyBuild encountered an error (at easybuild/easybuild-framework/easybuild/base/exceptions.py:126 in __init__): Sanity check failed: No '(RPATH)' found in 'readelf -d' output for /project/def-maintainers/boegelbot/rocky9/zen3/software/Bazel/7.4.1-GCCcore-13.3.0/bin/bazel (at easybuild/easybuild-framework/easybuild/framework/easyblock.py:3969 in _sanity_check_step)

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented May 6, 2025

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
node090.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/d3b02c604296ea4af579c0134cff89d9 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented May 6, 2025

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node090.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/fa70adc8015fdc2ef4b75defe52eeb7e for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented May 6, 2025 

== 2025-05-05 15:10:45,360 build_log.py:226 ERROR EasyBuild encountered an error (at easybuild/easybuild-framework/easybuild/base/exceptions.py:126 in __init__): Sanity check failed: No '(RPATH)' found in 'readelf -d' output for /project/def-maintainers/boegelbot/rocky9/zen3/software/Bazel/7.4.1-GCCcore-13.3.0/bin/bazel (at easybuild/easybuild-framework/easybuild/framework/easyblock.py:3969 in _sanity_check_step)

I guess that this build was done before we enabled rpathing with EB 5.0. That would explain why this check fails.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 6, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--disable-strict-rpath-sanity-check"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 6, 2025

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22839 EB_ARGS="--disable-strict-rpath-sanity-check" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22839 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6296

Test results coming soon (I hope)...

Details

- notification for comment with ID 2854400789 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 6, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/d5c990471db00d205ccde8a0e6c6fef0 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented May 6, 2025

Going in, thanks @Micket!

@jfgrimm jfgrimm modified the milestones: release after 5.0.1, 5.0.1 May 6, 2025
@jfgrimm jfgrimm merged commit 80f2cea into easybuilders:develop May 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Micket @boegelbot @jfgrimm @Thyre