{cae}[GCCcore/13.3.0] MagicVLSI v8.3.528 by alainvanhoof · Pull Request #23018 · easybuilders/easybuild-easyconfigs

alainvanhoof · 2025-06-03T19:22:10Z

(created using eb --new-pr)

use configopts as suggested Co-authored-by: Jasper Grimm <[email protected]>

github-actions · 2025-06-09T19:06:19Z

Updated software `MagicVLSI-8.3.528-GCC-13.3.0.eb`

Diff against MagicVLSI-8.3.528-GCCcore-13.3.0.eb

easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCCcore-13.3.0.eb

diff --git a/easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCCcore-13.3.0.eb b/easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCC-13.3.0.eb
index d2dfe66bdf..f7ca528dc3 100644
--- a/easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCCcore-13.3.0.eb
+++ b/easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCC-13.3.0.eb
@@ -10,7 +10,7 @@ description = """A venerable VLSI layout tool, written in the 1980's at Berkeley
  magic has remained popular with universities and small companies.
 """
 
-toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
+toolchain = {'name': 'GCC', 'version': '13.3.0'}
 toolchainopts = {'pic': True}
 
 source_urls = ['http://opencircuitdesign.com/magic/archive/']

Updated software `MagicVLSI-8.3.528-GCCcore-13.3.0.eb`

Diff against MagicVLSI-8.3.528-GCC-13.3.0.eb

easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCC-13.3.0.eb

diff --git a/easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCC-13.3.0.eb b/easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCCcore-13.3.0.eb
index f7ca528dc3..d2dfe66bdf 100644
--- a/easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCC-13.3.0.eb
+++ b/easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCCcore-13.3.0.eb
@@ -10,7 +10,7 @@ description = """A venerable VLSI layout tool, written in the 1980's at Berkeley
  magic has remained popular with universities and small companies.
 """
 
-toolchain = {'name': 'GCC', 'version': '13.3.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 toolchainopts = {'pic': True}
 
 source_urls = ['http://opencircuitdesign.com/magic/archive/']

…3528

Crivella · 2025-06-11T09:38:03Z

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/2ea949ad126c2d86b433bc19536bf5a7 for a full test report.

Crivella · 2025-06-11T09:43:39Z

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr23018"

boegelbot · 2025-06-11T09:50:08Z

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23018 EB_ARGS="--installpath /tmp/$USER/pr23018" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23018 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 6665

Test results coming soon (I hope)...

Details

- notification for comment with ID 2961966148 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-06-11T09:52:35Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/e85a0be72c1796133c71b0fd96a77a6d for a full test report.

Crivella · 2025-06-11T10:36:02Z

The configure script of this package seems to be making some assumption that the files coming from Tk and Tcl are going to be in the same directory, which is not the case here.

checking for wish executable... /home/crivella/.local/easybuild/software/Tk/8.6.14-GCCcore-13.3.0/bin/wish
checking for tclsh executable... Warning: Can't find executable for "tclsh".
no
checking GL/gl.h usability... yes
checking GL/gl.h presence... yes
checking for GL/gl.h... yes

I've created a PR to your branch that should fix this, but it would also be nice to have a sanity checks that fails in case tclsh is actually not found.

I see it is present in oa/magicInit.cpp and oa/magicOA.cpp but i am not sure what would allow for testing those pieces of code.

An alternative could be also to run the .tcl file fixed by the patch, but it would still not test that tclsh is being used properly by the tool

Fix wrong/hardcoded locations for tclsh

Crivella · 2025-06-12T14:32:29Z

@boegelbot please test @ jsc-zen3

Crivella · 2025-06-12T14:33:45Z

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/92b85000f9921e356287b20e78bdd2ec for a full test report.

boegelbot · 2025-06-12T14:40:11Z

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23018 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23018 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 6678

Test results coming soon (I hope)...

Details

- notification for comment with ID 2967080851 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-06-12T14:43:06Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/11d41cb682fc0ec477b6a2c5808f1d13 for a full test report.

Crivella

LGTM

Crivella · 2025-06-12T14:51:24Z

Going in, thanks @alainvanhoof!

alainvanhoof · 2025-06-12T15:05:41Z

Thanks for the mergeable patch @Crivella

adding easyconfigs: Magic-8.3.528-GCC-13.3.0.eb

77bea0f

github-actions Bot added the new label Jun 3, 2025

Added a space and a sanitycheck

8cc7484

jfgrimm reviewed Jun 4, 2025

View reviewed changes

Comment thread easybuild/easyconfigs/m/Magic/Magic-8.3.528-GCC-13.3.0.eb Outdated

alainvanhoof and others added 2 commits June 4, 2025 14:38

Update easybuild/easyconfigs/m/Magic/Magic-8.3.528-GCC-13.3.0.eb

b865493

use configopts as suggested Co-authored-by: Jasper Grimm <[email protected]>

New Name to avoid name-collision with other software

e9f2087

alainvanhoof changed the title ~~{cae}[GCC/13.3.0] Magic v8.3.528~~ {cae}[GCC/13.3.0] MagicVLSI v8.3.528 Jun 4, 2025

Delete easybuild/easyconfigs/m/Magic/Magic-8.3.528-GCC-13.3.0.eb

9f7867c

alainvanhoof changed the title ~~{cae}[GCC/13.3.0] MagicVLSI v8.3.528~~ {cae}[GCCcore/13.3.0] MagicVLSI v8.3.528 Jun 9, 2025

Changing to GCCcore as toolchain

c99b32c

github-actions Bot added update and removed new labels Jun 9, 2025

Delete easybuild/easyconfigs/m/MagicVLSI/MagicVLSI-8.3.528-GCC-13.3.0.eb

5976dab

github-actions Bot added new and removed update labels Jun 9, 2025

alainvanhoof and others added 2 commits June 9, 2025 21:15

Merge branch 'easybuilders:develop' into 20250603212207_new_pr_Magic8…

b3e8805

…3528

Added binutils as a builddependency

025cd06

Crivella added this to the next release (5.1.1?) milestone Jun 11, 2025

Fix wrong/hardcoded locations for tclsh

796e04d

Crivella mentioned this pull request Jun 11, 2025

Fix wrong/hardcoded locations for tclsh alainvanhoof/easybuild-easyconfigs#1

Merged

Merge pull request #1 from Crivella/pr-23018

0043744

Fix wrong/hardcoded locations for tclsh

Crivella approved these changes Jun 12, 2025

View reviewed changes

Crivella merged commit 0c60b22 into easybuilders:develop Jun 12, 2025
8 checks passed

Conversation

alainvanhoof commented Jun 3, 2025

Uh oh!

Uh oh!

github-actions Bot commented Jun 9, 2025

Updated software MagicVLSI-8.3.528-GCC-13.3.0.eb

Updated software MagicVLSI-8.3.528-GCCcore-13.3.0.eb

Uh oh!

Crivella commented Jun 11, 2025

Uh oh!

Crivella commented Jun 11, 2025

Uh oh!

boegelbot commented Jun 11, 2025

Uh oh!

boegelbot commented Jun 11, 2025

Uh oh!

Crivella commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Crivella commented Jun 12, 2025

Uh oh!

Crivella commented Jun 12, 2025

Uh oh!

boegelbot commented Jun 12, 2025

Uh oh!

boegelbot commented Jun 12, 2025

Uh oh!

Crivella left a comment

Choose a reason for hiding this comment

Uh oh!

Crivella commented Jun 12, 2025

Uh oh!

Uh oh!

alainvanhoof commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Updated software `MagicVLSI-8.3.528-GCC-13.3.0.eb`

Updated software `MagicVLSI-8.3.528-GCCcore-13.3.0.eb`

Crivella commented Jun 11, 2025 •

edited

Loading