{vis}[GCCcore/13.3.0] GTKWave-GTK3 v3.3.123 by alainvanhoof · Pull Request #23020 · easybuilders/easybuild-easyconfigs

alainvanhoof · 2025-06-03T19:33:24Z

(created using eb --new-pr)

jfgrimm · 2025-06-04T12:43:17Z

+GTKWave is a fully featured GTK+ based wave viewer for Unix
+"""
+
+toolchain = {'name': 'GCC', 'version': '13.3.0'}


any particular reason for this to be at GCC level instead of GCCcore?

Our users are slowly getting used to using modules. To avoid confusion in the module names we are using only GCC and FOSS tool chains. So not a technical reason. I already "downgraded" the names/toolchains from foss-2024a to GCC-13.3.0 for the newer versions and back then it created a lot of tickets.

in the EB repo we prefer to use GCCcore over GCC for software that is not performance-critical, so it can be reused as dependency in other toolchains (e.g. intel).

Indeed, it avoids unnecessary duplication of easyconfigs across multiple toolchains.
Locally, you can of course do what you like - keeping it at GCC level with custom easyconfigs or hooks

Good points, I'll update this to GCCcore.

github-actions · 2025-06-09T11:50:08Z

Updated software `GTKWave-GTK3-3.3.123-GCC-13.3.0.eb`

Diff against GTKWave-GTK3-3.3.123-GCCcore-13.3.0.eb

easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCCcore-13.3.0.eb

diff --git a/easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCCcore-13.3.0.eb b/easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCC-13.3.0.eb
index a87957f786..7093c20874 100644
--- a/easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCCcore-13.3.0.eb
+++ b/easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCC-13.3.0.eb
@@ -8,7 +8,7 @@ description = """
 GTKWave is a fully featured GTK+ based wave viewer for Unix
 """
 
-toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
+toolchain = {'name': 'GCC', 'version': '13.3.0'}
 toolchainopts = {'pic': True}
 
 source_urls = ['https://gtkwave.sourceforge.net/']

Updated software `GTKWave-GTK3-3.3.123-GCCcore-13.3.0.eb`

Diff against GTKWave-GTK3-3.3.123-GCC-13.3.0.eb

easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCC-13.3.0.eb

diff --git a/easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCC-13.3.0.eb b/easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCCcore-13.3.0.eb
index 7093c20874..a87957f786 100644
--- a/easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCC-13.3.0.eb
+++ b/easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCCcore-13.3.0.eb
@@ -8,7 +8,7 @@ description = """
 GTKWave is a fully featured GTK+ based wave viewer for Unix
 """
 
-toolchain = {'name': 'GCC', 'version': '13.3.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 toolchainopts = {'pic': True}
 
 source_urls = ['https://gtkwave.sourceforge.net/']

…13.3.0.eb

Crivella · 2025-06-11T11:24:14Z

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/bfa3ef40a8ea52e08bc55b1189fa3421 for a full test report.

Crivella · 2025-06-11T11:36:16Z

From the configure step

  LIBZ_CFLAGS           : 
  LIBZ_LDADD            : -lz

  LIBBZ2_CFLAGS         : 
  LIBBZ2_LDADD          : -lbz2

  LIBXZ_CFLAGS          : -D_WAVE_HAVE_XZ
  LIBXZ_LDADD           : -llzma

I see that zlib XZ and bzip2 are being linked but are not included as direct dependencies.
In this case the proper EB libraries are still being picked up because they are indirect dependencies.
@jfgrimm I am wondering if this EC should also include them to future-proof it against them being removed from the dependency packages

Also @alainvanhoof , are GTK and Tcl/Tk mutually exclusive or should we try to cover all possible deps?

  TCL_INCLUDE_SPEC      : 
  TCL_LIB_SPEC          : 
  TCL_LDADD             : 
  TCL_DEFADD            : 

  TK_INCLUDE_SPEC       : 
  TK_LIB_SPEC           : 
  TK_LDADD              :

jfgrimm · 2025-06-11T12:24:48Z

I see that zlib XZ and bzip2 are being linked but are not included as direct dependencies.
In this case the proper EB libraries are still being picked up because they are indirect dependencies.
@jfgrimm I am wondering if this EC should also include them to future-proof it against them being removed from the dependency packages

@Crivella that's something we're not consistent on in other easyconfigs, so I wouldn't worry about it too much. If we wanted consistency, we would really need to introduce some (optional) sanity checks in EB that ensure direct dependencies are specified in the easyconfig

Crivella · 2025-06-11T12:58:34Z

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr23020"

boegelbot · 2025-06-11T13:00:08Z

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23020 EB_ARGS="--installpath /tmp/$USER/pr23020" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23020 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 6669

Test results coming soon (I hope)...

Details

- notification for comment with ID 2962605403 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-06-11T13:02:51Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/bf32a5e6c1f585d7c651d263c468068a for a full test report.

alainvanhoof · 2025-06-12T11:30:33Z

Also @alainvanhoof , are GTK and Tcl/Tk mutually exclusive or should we try to cover all possible deps?

@Crivella It looks like ( https://gtkwave.sourceforge.net/ ) the software is favoring GTK and considers Tcl/Tk legacy, so I never looked at the TCL/TK option and i do not think we need to include it.

Crivella · 2025-06-12T14:23:32Z

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/d29ca56b617c541e74e62819b00ead16 for a full test report.

Crivella

LGTM

Crivella · 2025-06-12T14:26:57Z

Going in, thanks @alainvanhoof!

adding easyconfigs: GTKWave-GTK3-3.3.123-GCC-13.3.0.eb

9f2b82b

github-actions Bot added the new label Jun 3, 2025

Added a space

7e23d63

jfgrimm reviewed Jun 4, 2025

View reviewed changes

Changing to GCCcore as toolchain

28c439d

github-actions Bot added update and removed new labels Jun 9, 2025

alainvanhoof changed the title ~~{vis}[GCC/13.3.0] GTKWave-GTK3 v3.3.123~~ {vis}[GCCcore/13.3.0] GTKWave-GTK3 v3.3.123 Jun 9, 2025

Delete easybuild/easyconfigs/g/GTKWave-GTK3/GTKWave-GTK3-3.3.123-GCC-…

7953a00

…13.3.0.eb

github-actions Bot added new and removed update labels Jun 9, 2025

Added binutils as a builddependency

ca3e027

Crivella approved these changes Jun 12, 2025

View reviewed changes

Crivella added this to the next release (5.1.1?) milestone Jun 12, 2025

Crivella merged commit bb6295a into easybuilders:develop Jun 12, 2025
8 checks passed

Conversation

alainvanhoof commented Jun 3, 2025

Uh oh!

jfgrimm Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

alainvanhoof Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

smoors Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

jfgrimm Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

alainvanhoof Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 9, 2025

Updated software GTKWave-GTK3-3.3.123-GCC-13.3.0.eb

Updated software GTKWave-GTK3-3.3.123-GCCcore-13.3.0.eb

Uh oh!

Crivella commented Jun 11, 2025

Uh oh!

Crivella commented Jun 11, 2025

Uh oh!

jfgrimm commented Jun 11, 2025

Uh oh!

Crivella commented Jun 11, 2025

Uh oh!

boegelbot commented Jun 11, 2025

Uh oh!

boegelbot commented Jun 11, 2025

Uh oh!

alainvanhoof commented Jun 12, 2025

Uh oh!

Crivella commented Jun 12, 2025

Uh oh!

Crivella left a comment

Choose a reason for hiding this comment

Uh oh!

Crivella commented Jun 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Updated software `GTKWave-GTK3-3.3.123-GCC-13.3.0.eb`

Updated software `GTKWave-GTK3-3.3.123-GCCcore-13.3.0.eb`