Skip to content

fix source URL for c-ares#23057

Merged
boegel merged 2 commits intoeasybuilders:developfrom
sassy-crick:20250606222831_new_pr_c-ares1172
Jun 7, 2025
Merged

fix source URL for c-ares#23057
boegel merged 2 commits intoeasybuilders:developfrom
sassy-crick:20250606222831_new_pr_c-ares1172

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Jun 6, 2025

(created using eb --new-pr)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2025

Updated software c-ares-1.17.2-GCCcore-10.2.0.eb

Diff against c-ares-1.27.0-GCCcore-13.2.0.eb

easybuild/easyconfigs/c/c-ares/c-ares-1.27.0-GCCcore-13.2.0.eb

diff --git a/easybuild/easyconfigs/c/c-ares/c-ares-1.27.0-GCCcore-13.2.0.eb b/easybuild/easyconfigs/c/c-ares/c-ares-1.17.2-GCCcore-10.2.0.eb
index ea5f2f32b1..12d6968eb6 100644
--- a/easybuild/easyconfigs/c/c-ares/c-ares-1.27.0-GCCcore-13.2.0.eb
+++ b/easybuild/easyconfigs/c/c-ares/c-ares-1.17.2-GCCcore-10.2.0.eb
@@ -1,25 +1,19 @@
 easyblock = 'ConfigureMake'
 
 name = 'c-ares'
-version = '1.27.0'
+version = '1.17.2'
 
-homepage = 'https://c-ares.org/'
+homepage = 'https://c-ares.haxx.se'
 description = "c-ares is a C library for asynchronous DNS requests (including name resolves)"
 
-toolchain = {'name': 'GCCcore', 'version': '13.2.0'}
+toolchain = {'name': 'GCCcore', 'version': '10.2.0'}
 toolchainopts = {'pic': True}
 
-github_account = 'c-ares'
-source_urls = [GITHUB_SOURCE]
-sources = ['%s-%s.tar.gz' % (name.replace('-', ''), version.replace('.', '_'))]
-checksums = ['de6a839d47b93174ba260187a084027ea681a91ffe12f2d5f20645652eae246c']
+source_urls = ['https://github.com/c-ares/c-ares/releases/download/cares-%s' % version.replace('.', '_')]
+sources = [SOURCE_TAR_GZ]
+checksums = ['4803c844ce20ce510ef0eb83f8ea41fa24ecaae9d280c468c582d2bb25b3913d']
 
-builddependencies = [
-    ('binutils', '2.40'),
-    ('Autotools', '20220317'),
-]
-
-preconfigopts = 'autoreconf -i -f &&'
+builddependencies = [('binutils', '2.35')]
 
 sanity_check_paths = {
     'files': ['lib/libcares.a', 'lib/libcares.%s' % SHLIB_EXT, 'lib/pkgconfig/libcares.pc'],
Diff against c-ares-1.19.1-GCCcore-12.3.0.eb

easybuild/easyconfigs/c/c-ares/c-ares-1.19.1-GCCcore-12.3.0.eb

diff --git a/easybuild/easyconfigs/c/c-ares/c-ares-1.19.1-GCCcore-12.3.0.eb b/easybuild/easyconfigs/c/c-ares/c-ares-1.17.2-GCCcore-10.2.0.eb
index 51111d7278..12d6968eb6 100644
--- a/easybuild/easyconfigs/c/c-ares/c-ares-1.19.1-GCCcore-12.3.0.eb
+++ b/easybuild/easyconfigs/c/c-ares/c-ares-1.17.2-GCCcore-10.2.0.eb
@@ -1,25 +1,19 @@
 easyblock = 'ConfigureMake'
 
 name = 'c-ares'
-version = '1.19.1'
+version = '1.17.2'
 
-homepage = 'https://c-ares.org/'
+homepage = 'https://c-ares.haxx.se'
 description = "c-ares is a C library for asynchronous DNS requests (including name resolves)"
 
-toolchain = {'name': 'GCCcore', 'version': '12.3.0'}
+toolchain = {'name': 'GCCcore', 'version': '10.2.0'}
 toolchainopts = {'pic': True}
 
-github_account = 'c-ares'
-source_urls = [GITHUB_SOURCE]
-sources = ['%s-%s.tar.gz' % (name.replace('-', ''), version.replace('.', '_'))]
-checksums = ['9eadec0b34015941abdf3eb6aead694c8d96a192a792131186a7e0a86f2ad6d9']
+source_urls = ['https://github.com/c-ares/c-ares/releases/download/cares-%s' % version.replace('.', '_')]
+sources = [SOURCE_TAR_GZ]
+checksums = ['4803c844ce20ce510ef0eb83f8ea41fa24ecaae9d280c468c582d2bb25b3913d']
 
-builddependencies = [
-    ('binutils', '2.40'),
-    ('Autotools', '20220317'),
-]
-
-preconfigopts = 'autoreconf -i -f &&'
+builddependencies = [('binutils', '2.35')]
 
 sanity_check_paths = {
     'files': ['lib/libcares.a', 'lib/libcares.%s' % SHLIB_EXT, 'lib/pkgconfig/libcares.pc'],
Diff against c-ares-1.18.1-GCCcore-11.3.0.eb

easybuild/easyconfigs/c/c-ares/c-ares-1.18.1-GCCcore-11.3.0.eb

diff --git a/easybuild/easyconfigs/c/c-ares/c-ares-1.18.1-GCCcore-11.3.0.eb b/easybuild/easyconfigs/c/c-ares/c-ares-1.17.2-GCCcore-10.2.0.eb
index aacc900a81..12d6968eb6 100644
--- a/easybuild/easyconfigs/c/c-ares/c-ares-1.18.1-GCCcore-11.3.0.eb
+++ b/easybuild/easyconfigs/c/c-ares/c-ares-1.17.2-GCCcore-10.2.0.eb
@@ -1,25 +1,19 @@
 easyblock = 'ConfigureMake'
 
 name = 'c-ares'
-version = '1.18.1'
+version = '1.17.2'
 
-homepage = 'https://c-ares.org/'
+homepage = 'https://c-ares.haxx.se'
 description = "c-ares is a C library for asynchronous DNS requests (including name resolves)"
 
-toolchain = {'name': 'GCCcore', 'version': '11.3.0'}
+toolchain = {'name': 'GCCcore', 'version': '10.2.0'}
 toolchainopts = {'pic': True}
 
-github_account = 'c-ares'
-source_urls = [GITHUB_SOURCE]
-sources = ['%s-%s.tar.gz' % (name.replace('-', ''), version.replace('.', '_'))]
-checksums = ['414872549eec4e221b576693fdc9c9bce44ff794d0f1f06f2515b56a7f6ec9c9']
+source_urls = ['https://github.com/c-ares/c-ares/releases/download/cares-%s' % version.replace('.', '_')]
+sources = [SOURCE_TAR_GZ]
+checksums = ['4803c844ce20ce510ef0eb83f8ea41fa24ecaae9d280c468c582d2bb25b3913d']
 
-builddependencies = [
-    ('binutils', '2.38'),
-    ('Autotools', '20220317'),
-]
-
-preconfigopts = 'autoreconf -i -f &&'
+builddependencies = [('binutils', '2.35')]
 
 sanity_check_paths = {
     'files': ['lib/libcares.a', 'lib/libcares.%s' % SHLIB_EXT, 'lib/pkgconfig/libcares.pc'],

@github-actions github-actions Bot added the change label Jun 6, 2025
@sassy-crick sassy-crick added bug fix and removed update labels Jun 6, 2025
@sassy-crick
Copy link
Copy Markdown
Collaborator Author

sassy-crick commented Jun 6, 2025

@boegelbot please test @ jsc-zen3

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

sassy-crick commented Jun 6, 2025

I have removed the c-ares-1.17.2-GCCcore-10.2.0.eb as it is outdated it seems.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 6, 2025

@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23057 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23057 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6631

Test results coming soon (I hope)...

Details

- notification for comment with ID 2950899496 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 6, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/7e2f00b0203ed03ab8311d486fc126e2 for a full test report.

@boegel boegel changed the title Download-URL fixed fix source URL for c-ares Jun 7, 2025
boegel
boegel approved these changes Jun 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel removed the change label Jun 7, 2025
@boegel boegel added this to the next release (5.1.1?) milestone Jun 7, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 7, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3507.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/a75f8df7690c545996e5327271418dcf for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 7, 2025

Going in, thanks @sassy-crick!

@boegel boegel merged commit 18c6eea into easybuilders:develop Jun 7, 2025
8 checks passed
@sassy-crick sassy-crick deleted the 20250606222831_new_pr_c-ares1172 branch June 7, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@sassy-crick @boegelbot @boegel