Skip to content

fix sanity_check_commands for MinPath 1.6 and add GCCcore/12.3.0 version#23151

Merged
verdurin merged 2 commits intoeasybuilders:developfrom
jfgrimm:20250619123349_new_pr_MinPath16
Jun 19, 2025
Merged

fix sanity_check_commands for MinPath 1.6 and add GCCcore/12.3.0 version#23151
verdurin merged 2 commits intoeasybuilders:developfrom
jfgrimm:20250619123349_new_pr_MinPath16

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Jun 19, 2025

this sanity check assumes we're running in the install dir, but since EB 5.0 we run the sanity check in a temporary directory

(created using eb --new-pr)

@jfgrimm jfgrimm requested a review from verdurin June 19, 2025 11:35
@jfgrimm jfgrimm added bug fix and removed change labels Jun 19, 2025
@jfgrimm jfgrimm added the update label Jun 19, 2025
@jfgrimm jfgrimm added this to the 5.x milestone Jun 19, 2025
@github-actions
Copy link
Copy Markdown

Updated software MinPath-1.6-GCCcore-12.3.0.eb

Diff against MinPath-1.6-GCCcore-11.2.0.eb

easybuild/easyconfigs/m/MinPath/MinPath-1.6-GCCcore-11.2.0.eb

diff --git a/easybuild/easyconfigs/m/MinPath/MinPath-1.6-GCCcore-11.2.0.eb b/easybuild/easyconfigs/m/MinPath/MinPath-1.6-GCCcore-12.3.0.eb
index d15a861056..7f059093d3 100644
--- a/easybuild/easyconfigs/m/MinPath/MinPath-1.6-GCCcore-11.2.0.eb
+++ b/easybuild/easyconfigs/m/MinPath/MinPath-1.6-GCCcore-12.3.0.eb
@@ -10,7 +10,7 @@ description = """MinPath (Minimal set of Pathways) is a parsimony approach for b
  using protein family predictions, achieving a more conservative, yet more faithful, estimation of the biological
  pathways for a query dataset."""
 
-toolchain = {'name': 'GCCcore', 'version': '11.2.0'}
+toolchain = {'name': 'GCCcore', 'version': '12.3.0'}
 
 source_urls = ['https://github.com/mgtools/MinPath/archive/']
 sources = [{'download_filename': '%s.tar.gz' % local_commit, 'filename': SOURCE_TAR_GZ}]
@@ -21,7 +21,7 @@ checksums = [
 ]
 
 dependencies = [
-    ('Python', '3.9.6'),
+    ('Python', '3.11.3'),
     ('GLPK', '5.0'),
 ]
 

@jfgrimm jfgrimm changed the title fix sanity_check_commands for MinPath 1.6 fix sanity_check_commands for MinPath 1.6 and add GCCcore/12.3.0 version Jun 19, 2025
@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Jun 19, 2025

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node106.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/e3aa15cad7f99202857b016e1e8d19a1 for a full test report.

@jfgrimm jfgrimm removed the change label Jun 19, 2025
@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Jun 19, 2025

@boegelbot: please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23151 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23151 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6906

Test results coming soon (I hope)...

Details

- notification for comment with ID 2987768728 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/f8237b75ac6ef470b7312d20cb025061 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.11.11
See https://gist.github.com/verdurin/6e4d8451f63736854dc0191cbe9da937 for a full test report.

Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin modified the milestones: 5.x, next release (5.1.1?) Jun 19, 2025
@verdurin
Copy link
Copy Markdown
Member

Going in, thanks @jfgrimm!

@verdurin verdurin merged commit adc4389 into easybuilders:develop Jun 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants