Skip to content

Revert some changes to phono3py out of abundance of caution#23207

Merged
branfosj merged 3 commits intoeasybuilders:developfrom
ocaisa:20250625095508_new_pr_phono3py270
Jun 25, 2025
Merged

Revert some changes to phono3py out of abundance of caution#23207
branfosj merged 3 commits intoeasybuilders:developfrom
ocaisa:20250625095508_new_pr_phono3py270

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Jun 25, 2025 •
edited
Loading

(created using eb --new-pr)

In the final library for phono3py I see some symbols related to lapacke:

$ nm -u /home/ocaisa/eessi/versions/2023.06/software/linux/x86_64/intel/icelake/software/phono3py/2.7.0-foss-2023a/lib/python3.11/site-packages/phono3py/_phono3py.cpython-311-x86_64-linux-gnu.so
                 U LAPACKE_dgesvd
                 U LAPACKE_dsyev
                 U LAPACKE_dsyevd_work
                 U LAPACKE_zheev

This is not a hill I am willing to die on so, so I revert/update some of the changes of #23198 to ensure that the math libraries are linked (even though I have no way to sanity check...or know that they are even needed).

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jun 25, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/327e70a0eca7dd02b1cff0998a86edc3 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jun 25, 2025

@boegelbot please test @ jsc-zen3

@branfosj branfosj added this to the next release (5.1.1?) milestone Jun 25, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 25, 2025

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23207 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23207 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7001

Test results coming soon (I hope)...

Details

- notification for comment with ID 3003860039 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 25, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/fe63342b42a3f87dacc49a0f30c41265 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jun 25, 2025

Going in, thanks @ocaisa!

@branfosj branfosj merged commit 28bcaf3 into easybuilders:develop Jun 25, 2025
8 checks passed
@branfosj branfosj mentioned this pull request Jun 25, 2025
Merged
1 task
@ocaisa ocaisa deleted the 20250625095508_new_pr_phono3py270 branch June 25, 2025 09:01
@boegel boegel added bug fix and removed change labels Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ocaisa @branfosj @boegelbot @boegel