I've seen in the docs there is also the option to build with shared libraries.
I was wondering if it should be favored here, or if we could even follow an approach like
https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/a/Abseil/Abseil-20240722.0-GCCcore-13.3.0.eb
where we build the same package twice, once to get the static and again to get the dynamic library (the trick in that EC is to have configopts as a list, with all the options you want to build for)

I've seen in the docs there is also the option to build with shared libraries.

I wanted to follow the same convention as the other three easyconfigs for the TRIQS-based codes (TRIQS-cthyb, TRIQS-tprf and TRIQS-dft_tools). They all feature the CMake flag BUILD_SHARED_LIBS, which is switched off by default. The only difference between them and my project is that I mention the flag in the docs.

Anyhow, I could totally build the shared libraries if this is the preferred way.

https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/a/Abseil/Abseil-20240722.0-GCCcore-13.3.0.eb

That file contains the following comment,

# Build static and shared libraries, static last so they get preferred by CMake consumers
# For backwards compatibility only. Future builds should only build static libs to avoid excessive linkage.

So, should really do a dual build?

Not being familiar with the tool i am not sure if the libraries would ever be used as a dependency for something else, or only for the tool itself.

If they are only for the tool than i think static only is fine.
Otherwise having the dynamic ones might be prefered

If they are only for the tool than i think static only is fine.
Otherwise having the dynamic ones might be prefered

The project offers a public C++ API (it installs header files), but realistically speaking that library will probably be consumed only by the Python module of the tool itself.

@boegelbot please test @ jsc-zen3

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23242 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23242 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

• exit code: 0
• output:

Submitted batch job 7063

Test results coming soon (I hope)...

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/a231fed0341483943cc9455b4fb30aa2 for a full test report.

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/adb753efcb247b2d7451d1a5b82bc252 for a full test report.

Going in, thanks @krivenko!