Skip to content

Remove packaging extension from scikit-build-0.17.6-GCCcore-13.3.0.eb#23258

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
WilleBell:20250702114737_new_pr_scikit-build0176
Jul 2, 2025
Merged

Remove packaging extension from scikit-build-0.17.6-GCCcore-13.3.0.eb#23258
branfosj merged 1 commit intoeasybuilders:developfrom
WilleBell:20250702114737_new_pr_scikit-build0176

Conversation

@WilleBell
Copy link
Copy Markdown
Contributor

@WilleBell WilleBell commented Jul 2, 2025

(created using eb --new-pr)
A newer version of packaging is included in Python v3.12.3 I'm not sure why packaging v23.1 extension was included in scikit-build.

@github-actions github-actions Bot added the change label Jul 2, 2025
@WilleBell WilleBell changed the title remove ext packaging Remove extension packaging from scikit-build-0.17.6-GCCcore-13.3.0.eb Jul 2, 2025
@WilleBell
Copy link
Copy Markdown
Contributor Author

Test report by @WilleBell
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node601.hydra.os - Linux Rocky Linux 8.10, x86_64, AMD EPYC 9384X 32-Core Processor, Python 3.6.8
See https://gist.github.com/WilleBell/e39d7c664087199821f9983f56c68d3b for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 2, 2025

A newer version of packaging is included in Python v3.12.3 I'm not sure why packaging v23.1 extension was included in scikit-build.

It does not look to be needed in scikit-build-0.17.6-GCCcore-12.3.0.eb or scikit-build-0.17.6-GCCcore-13.2.0.eb either.

@branfosj branfosj added this to the release after 5.1.1 milestone Jul 2, 2025
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 2, 2025

A newer version of packaging is included in Python v3.12.3 I'm not sure why packaging v23.1 extension was included in scikit-build.

It does not look to be needed in scikit-build-0.17.6-GCCcore-12.3.0.eb or scikit-build-0.17.6-GCCcore-13.2.0.eb either.

I expect it was needed in those two until we did #19651 and then it got copied over into scikit-build-0.17.6-GCCcore-13.3.0.eb. So I've opened #23259 to remove it from those two as well.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 2, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/070f651597c4ccb3e32e69c41974d3ee for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 2, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23258 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23258 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7079

Test results coming soon (I hope)...

Details

- notification for comment with ID 3027276991 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/8b65c8b17c6ccda8faeb0665fb59b792 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 2, 2025

Going in, thanks @WilleBell!

@branfosj branfosj merged commit 4df77c4 into easybuilders:develop Jul 2, 2025
8 checks passed
@boegel boegel modified the milestones: release after 5.1.1, 5.1.1 Jul 4, 2025
@boegel boegel changed the title Remove extension packaging from scikit-build-0.17.6-GCCcore-13.3.0.eb Remove packaging extension from scikit-build-0.17.6-GCCcore-13.3.0.eb Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants