Skip to content

Switch to correct Pillow dep (non SIMD as its not actually updated) for matplotlib in 2024a#23264

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
Micket:20250702144554_new_pr_matplotlib392
Jul 2, 2025
Merged

Switch to correct Pillow dep (non SIMD as its not actually updated) for matplotlib in 2024a#23264
branfosj merged 1 commit intoeasybuilders:developfrom
Micket:20250702144554_new_pr_matplotlib392

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Jul 2, 2025 •
edited
Loading

(created using eb --new-pr)

Our Pillow-SIMD 10.4.0 aren't actually using pillow-simd sources, so I suggeest we switch matplotlib back to using this instead.

I don't think there is much harm to make this change. If anyone doesn't rebuild, it stays using normal Pillow inside Pillow-SIMD, so, no biggie.

@github-actions github-actions Bot added the change label Jul 2, 2025
@Micket Micket added this to the 5.1.1 milestone Jul 2, 2025
@Micket Micket changed the title Switch to correct Pillow dep (non SIMD as its not actually updated) Switch to correct Pillow dep (non SIMD as its not actually updated) for matplotlib in 2024a Jul 2, 2025
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 2, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/78697699c49c9d78a71a23c75247aa34 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 2, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 2, 2025

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23264 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23264 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7094

Test results coming soon (I hope)...

Details

- notification for comment with ID 3028489232 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 2, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/460704e026a4fece22847961c9f04bc7 for a full test report.

boegel
boegel approved these changes Jul 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 2, 2025

Going in, thanks @Micket!

@branfosj branfosj merged commit cb89ea2 into easybuilders:develop Jul 2, 2025
8 checks passed
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 2, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3512.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/4915b769c74f40087508b7bc15cce09a for a full test report.

@Micket Micket deleted the 20250702144554_new_pr_matplotlib392 branch July 3, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

5.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Micket @branfosj @boegelbot @boegel