Skip to content

remove default separate_build_dir = True from gmsh#23286

Merged
Crivella merged 1 commit intoeasybuilders:developfrom
branfosj:20250703085621_new_pr_gmsh4111
Jul 3, 2025
Merged

remove default separate_build_dir = True from gmsh#23286
Crivella merged 1 commit intoeasybuilders:developfrom
branfosj:20250703085621_new_pr_gmsh4111

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jul 3, 2025

(created using eb --new-pr)

@github-actions github-actions Bot added the change label Jul 3, 2025
@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Jul 3, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr-23286"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 3, 2025

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23286 EB_ARGS="--installpath /tmp/$USER/pr-23286" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23286 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7111

Test results coming soon (I hope)...

Details

- notification for comment with ID 3031481067 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 3, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 11 out of 11 (4 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/39a1dc7632911b9c009435ca4949ecde for a full test report.

Crivella
Crivella approved these changes Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Crivella Crivella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Crivella Crivella added this to the 5.1.1 milestone Jul 3, 2025
@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Jul 3, 2025

Going in, thanks @branfosj!

@Crivella Crivella merged commit 3cabe89 into easybuilders:develop Jul 3, 2025
8 checks passed
@branfosj branfosj deleted the 20250703085621_new_pr_gmsh4111 branch July 3, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Crivella Crivella Crivella approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

5.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @Crivella @boegelbot