Skip to content

remove default separate_build_dir = True from cppzmq#23329

Merged
Micket merged 1 commit intoeasybuilders:developfrom
branfosj:20250704202945_new_pr_cppzmq490
Jul 5, 2025
Merged

remove default separate_build_dir = True from cppzmq#23329
Micket merged 1 commit intoeasybuilders:developfrom
branfosj:20250704202945_new_pr_cppzmq490

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jul 4, 2025

(created using eb --new-pr)

@github-actions github-actions Bot added the change label Jul 4, 2025
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jul 4, 2025

@boegelbot please test @ jsc-zen3

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jul 4, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/4aeda7e55ee40a103762beecf7842236 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 4, 2025

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23329 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23329 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7149

Test results coming soon (I hope)...

Details

- notification for comment with ID 3037132421 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 4, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/e49077d443d8fbebafac3dfb3eaca81d for a full test report.

@branfosj branfosj added this to the release after 5.1.1 milestone Jul 5, 2025
Micket
Micket approved these changes Jul 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 09f670c into easybuilders:develop Jul 5, 2025
8 checks passed
@branfosj branfosj deleted the 20250704202945_new_pr_cppzmq490 branch July 5, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

5.1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegelbot @Micket