{bio}[intel/2016a] EggLib v2.1.10 (REVIEW)#2335
Conversation
|
This works, but maybe there's too much trickery going on in here, which should be handled via an easyblock instead... @wpoely86: please review? |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5697/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
There was a problem hiding this comment.
shouldn't we stick to .10 to avoid dep hell?
There was a problem hiding this comment.
We'll have to move to .11 sooner or later. I already did for DOLFIN, for example.
And we're really close to moving on to intel/2016a now, so jumping to Python 2.7.11 is going to happen anyway.
There was a problem hiding this comment.
for 2016a sure, but I would stick to .10 for intel2015b
|
This one feels dirty. |
|
@wpoely86: it does, it needs an easyblock for sure |
|
@wpoely86: updated, now requires easybuilders/easybuild-easyblocks#811 |
6109405 to
46d5f0a
Compare
|
Test report by @boegel |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5733/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5734/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5745/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Jenkins: test this please |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5761/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
All cleaned up, good to go, thanks for the review @wpoely86! |
{bio}[intel/2016a] EggLib v2.1.10 (REVIEW)
(created using
eb --new-pr)requires easybuilders/easybuild-easyblocks#811