Skip to content

add libiconv build dependency to libarchive 3.8.1#23353

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
Thyre:20250709101023_new_pr_libarchive381
Jul 9, 2025
Merged

add libiconv build dependency to libarchive 3.8.1#23353
jfgrimm merged 1 commit intoeasybuilders:developfrom
Thyre:20250709101023_new_pr_libarchive381

Conversation

@Thyre
Copy link
Copy Markdown
Collaborator

@Thyre Thyre commented Jul 9, 2025 •
edited
Loading

(created using eb --new-pr)

Fixes following build failure seen on my Arch Linux machine:

eb-shell> make
make  all-am
make[1]: Entering directory '/data/EasyBuild-develop/build/libarchive/3.8.1/GCCcore-14.3.0/libarchive-3.8.1'
  CC       libarchive/archive_version_details.lo
libarchive/archive_version_details.c: In function 'archive_libiconv_version':
libarchive/archive_version_details.c:503:22: error: '_libiconv_version' undeclared (first use in this function); did you mean 'zlib_version'?
  503 |         char major = _libiconv_version >> 8;
      |                      ^~~~~~~~~~~~~~~~~
      |                      zlib_version
libarchive/archive_version_details.c:503:22: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:7291: libarchive/archive_version_details.lo] Error 1
make[1]: Leaving directory '/data/EasyBuild-develop/build/libarchive/3.8.1/GCCcore-14.3.0/libarchive-3.8.1'
make: *** [Makefile:4197: all] Error 2

For some reason, earlier versions seem to not be affected.

@github-actions github-actions Bot added the change label Jul 9, 2025
@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Jul 9, 2025 •
edited
Loading

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x AMD Navi 48 [Radeon RX 9070/9070 XT/9070 GRE] (device id: 0x7550, gfx: gfx1201, driver: 6.15.5-arch1-1), 1 x AMD Raphael (device id: 0x164e, gfx: gfx1036, driver:6.15.5-arch1-1), Python 3.13.5
See https://gist.github.com/Thyre/69deec4e812e93d036be138275566b48 for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Jul 9, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
ZAM054 - Linux Zorin OS 17, x86_64, 12th Gen Intel(R) Core(TM) i7-1260P, 1 x NVIDIA NVIDIA GeForce MX550, 570.133.07, Python 3.10.12
See https://gist.github.com/Thyre/ca6d67487955887f2817e29b450c6c6d for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Jul 9, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 9, 2025

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23353 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23353 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7173

Test results coming soon (I hope)...

Details

- notification for comment with ID 3051634974 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 9, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/38b6e9ffdb6f9f62867383dc54815167 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 9, 2025 •
edited
Loading

Test report by @jfgrimm
FAILED
Build succeeded for 1 out of 4 (1 easyconfigs in total)
node028.viking2.yor.alces.network - Linux Rocky Linux 8.10, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/a362b0892342f3ddadae74c8c2e67a17 for a full test report.

edit: issue with the ftpmirror I got assigned 🙃

@jfgrimm jfgrimm added bug fix and removed change labels Jul 9, 2025
@jfgrimm jfgrimm added this to the release after 5.1.1 milestone Jul 9, 2025
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 9, 2025

Test report by @jfgrimm
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in total)
node028.viking2.yor.alces.network - Linux Rocky Linux 8.10, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/bce8c7c2eb0aba7599ecc3e00fe3e3e3 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 9, 2025

Going in, thanks @Thyre!

@jfgrimm jfgrimm merged commit d04c345 into easybuilders:develop Jul 9, 2025
8 checks passed
@SebastianAchilles SebastianAchilles added the 2025b issues & PRs related to 2025b common toolchains label Jul 9, 2025
@boegel boegel changed the title {tools}[GCCcore/14.3.0] Add libiconv build dep to libarchive add libiconv build dependency to libarchive 3.8.1 Sep 26, 2025
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Feb 12, 2026

This actually seems also to be a runtime dependency, see EESSI/software-layer#1380 (comment). Opening up a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

2025b issues & PRs related to 2025b common toolchains bug fix

Projects

None yet

Milestone

5.1.2

Development

Successfully merging this pull request may close these issues.

5 participants

@Thyre @boegelbot @jfgrimm @ocaisa @SebastianAchilles