Skip to content

{geo}[GCCcore/13.3.0,foss/2024a] DIVEMesh v25.05, REEF3D v25.05_v2#23475

Merged
Crivella merged 4 commits intoeasybuilders:developfrom
sassy-crick:20250723182124_new_pr_DIVEMesh2505
Dec 17, 2025
Merged

{geo}[GCCcore/13.3.0,foss/2024a] DIVEMesh v25.05, REEF3D v25.05_v2#23475
Crivella merged 4 commits intoeasybuilders:developfrom
sassy-crick:20250723182124_new_pr_DIVEMesh2505

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

(created using eb --new-pr)

…-foss-2024a.eb and patches: REEF3D-25.05_v2-makefile.patch
@sassy-crick
Copy link
Copy Markdown
Collaborator Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23475 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23475 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7325

Test results coming soon (I hope)...

Details

- notification for comment with ID 3109521043 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/30811eb1a4fbb686995ec6612c98e394 for a full test report.

boegel
boegel previously requested changes Jul 30, 2025
Comment thread easybuild/easyconfigs/r/REEF3D/REEF3D-25.05_v2-makefile.patch
@Thyre Thyre added the 2024a issues & PRs related to 2024a common toolchains label Aug 18, 2025
@sassy-crick
Copy link
Copy Markdown
Collaborator Author

Test report by @sassy-crick
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
hp - Linux Debian GNU/Linux 12, x86_64, 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz, Python 3.11.2
See https://gist.github.com/sassy-crick/eefa49ab69967494c17165e299e3f19d for a full test report.

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23475 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23475 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7701

Test results coming soon (I hope)...

Details

- notification for comment with ID 3198643642 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/a7b240b926a2ad2b659a4ca3583cba7d for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Oct 10, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23475 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23475 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8268

Test results coming soon (I hope)...

Details

- notification for comment with ID 3389822260 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Oct 10, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
datenlager - Linux Ubuntu 24.04, x86_64, AMD Ryzen 7 3700X 8-Core Processor, Python 3.12.3
See https://gist.github.com/Thyre/83266549f06512bf1ac5003b65a50a0a for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/4d8bc7a5daf0e3139a23199534897a72 for a full test report.

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Dec 3, 2025

Test report by @Crivella
SUCCESS
Build succeeded for 3 out of 3 (total: 3 mins 45 secs) (2 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.14
See https://gist.github.com/Crivella/20ec6f4e5430044990f58da5df31823c for a full test report.

Comment thread easybuild/easyconfigs/d/DIVEMesh/DIVEMesh-25.05-GCCcore-13.3.0.eb Outdated
Comment thread easybuild/easyconfigs/r/REEF3D/REEF3D-25.05_v2-foss-2024a.eb Outdated
Copy link
Copy Markdown
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DIVEMesh seems to have an OPENMP flag, I guess we should enable this?
https://github.com/REEF3D/DIVEMesh/blob/master/Makefile#L8

Also, I think we may have to patch the Makefiles a bit (more) to make sure that it uses the compilers and flags set by EasyBuild. Both https://github.com/REEF3D/DIVEMesh/blob/master/Makefile and https://github.com/REEF3D/REEF3D/blob/master/Makefile have hardcoded values for stuff like CXX, CXXFLAGS, LDFLAGS, etc. We can replace most of the := by ?= to ensure that it won't override these flags.

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

Test report by @sassy-crick
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
hp - Linux Debian GNU/Linux 12, x86_64, 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz, Python 3.11.2
See https://gist.github.com/sassy-crick/7e09b8e4c78f407a56d22b876335cd83 for a full test report.

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

@boegelbot please test @ jsc-zen3

Comment thread easybuild/easyconfigs/r/REEF3D/REEF3D-25.05_v2-makefile.patch Outdated
@boegelbot
Copy link
Copy Markdown
Collaborator

@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23475 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23475 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9206

Test results coming soon (I hope)...

Details

- notification for comment with ID 3661440899 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (total: 4 mins 4 secs) (2 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/e42e93cfbc40d8cfd04d230e55914272 for a full test report.

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23475 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23475 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9208

Test results coming soon (I hope)...

Details

- notification for comment with ID 3661666590 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

Test report by @sassy-crick
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
hp - Linux Debian GNU/Linux 12, x86_64, 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz, Python 3.11.2
See https://gist.github.com/sassy-crick/35054781fc62ff54654bb1087e296070 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (total: 4 mins 4 secs) (2 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/6ea49a5338d58feb13162cd0c64e2356 for a full test report.

@Crivella
Copy link
Copy Markdown
Contributor

Test report by @Crivella
SUCCESS
Build succeeded for 2 out of 2 (total: 3 mins 4 secs) (2 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.14
See https://gist.github.com/Crivella/a3b3dddc3683230153e52ab26263467d for a full test report.

@Crivella Crivella added this to the next release (5.2.0) milestone Dec 17, 2025
Copy link
Copy Markdown
Contributor

@Crivella Crivella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Crivella Crivella dismissed stale reviews from boegel and bedroge December 17, 2025 09:01

Changes addressed in PR

@Crivella
Copy link
Copy Markdown
Contributor

Going in, thanks @sassy-crick!

@Crivella Crivella merged commit cfa38b5 into easybuilders:develop Dec 17, 2025
8 checks passed
@sassy-crick sassy-crick deleted the 20250723182124_new_pr_DIVEMesh2505 branch December 17, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2024a issues & PRs related to 2024a common toolchains new ready-to-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants