{geo}[GCCcore/13.3.0,foss/2024a] DIVEMesh v25.05, REEF3D v25.05_v2#23475
Conversation
…-foss-2024a.eb and patches: REEF3D-25.05_v2-makefile.patch
|
@boegelbot please test @ jsc-zen3 |
|
@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3109521043 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @sassy-crick |
|
@boegelbot please test @ jsc-zen3 |
|
@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3198643642 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3389822260 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @Thyre |
|
Test report by @boegelbot |
|
Test report by @Crivella |
bedroge
left a comment
There was a problem hiding this comment.
DIVEMesh seems to have an OPENMP flag, I guess we should enable this?
https://github.com/REEF3D/DIVEMesh/blob/master/Makefile#L8
Also, I think we may have to patch the Makefiles a bit (more) to make sure that it uses the compilers and flags set by EasyBuild. Both https://github.com/REEF3D/DIVEMesh/blob/master/Makefile and https://github.com/REEF3D/REEF3D/blob/master/Makefile have hardcoded values for stuff like CXX, CXXFLAGS, LDFLAGS, etc. We can replace most of the := by ?= to ensure that it won't override these flags.
|
Test report by @sassy-crick |
|
@boegelbot please test @ jsc-zen3 |
|
@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3661440899 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
@boegelbot please test @ jsc-zen3 |
|
@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3661666590 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @sassy-crick |
|
Test report by @boegelbot |
|
Test report by @Crivella |
Changes addressed in PR
|
Going in, thanks @sassy-crick! |
(created using
eb --new-pr)