Skip to content

{data}[GCCcore/13.2.0] MDSplus v7.153.3#23531

Merged
Crivella merged 4 commits intoeasybuilders:developfrom
SimonPinches:20250730100535_new_pr_MDSplus71533
Aug 5, 2025
Merged

{data}[GCCcore/13.2.0] MDSplus v7.153.3#23531
Crivella merged 4 commits intoeasybuilders:developfrom
SimonPinches:20250730100535_new_pr_MDSplus71533

Conversation

@SimonPinches
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@github-actions github-actions Bot added the new label Jul 30, 2025
@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Aug 4, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23531 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23531 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7480

Test results coming soon (I hope)...

Details

- notification for comment with ID 3150377777 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/51b543499da8b41a774e3a9219b400be for a full test report.

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Aug 4, 2025

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/035c24b084675e847b157b054164114a for a full test report.

@Crivella Crivella added this to the release after 5.1.1 milestone Aug 4, 2025
Copy link
Copy Markdown
Contributor

@Crivella Crivella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see from the logs that the bootstrap attempts to run git to update the submodules but fails due to the missing .git directory.

Is this the expected behavior (eg we want to skip the submodules update)?
In that case the proposed changes makes it clearer that we only want the files pulled in originally and are fine with git failing

Other-wise ideally we would want to pull in the changes ourselves through easybuild so that we can checksum them and pin them to a commit that we know works

Comment thread easybuild/easyconfigs/m/MDSplus/MDSplus-7.153.3-GCCcore-13.2.0.eb
Comment thread easybuild/easyconfigs/m/MDSplus/MDSplus-7.153.3-GCCcore-13.2.0.eb
@SimonPinches
Copy link
Copy Markdown
Contributor Author

I see from the logs that the bootstrap attempts to run git to update the submodules but fails due to the missing .git directory.

Is this the expected behavior (eg we want to skip the submodules update)? In that case the proposed changes makes it clearer that we only want the files pulled in originally and are fine with git failing

Other-wise ideally we would want to pull in the changes ourselves through easybuild so that we can checksum them and pin them to a commit that we know works

@Crivella, I think your solution is fine and have accepted your changes.

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Aug 5, 2025

@boegelbot please test @ jsc-zen3

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Aug 5, 2025

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/4a46ee723d901fbc7bcfb8f63bc0db64 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23531 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23531 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7490

Test results coming soon (I hope)...

Details

- notification for comment with ID 3154009729 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/4a95e7121779d45351d0f46a83d1632f for a full test report.

Copy link
Copy Markdown
Contributor

@Crivella Crivella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Aug 5, 2025

Going in, thanks @SimonPinches!

@Crivella Crivella merged commit fb4e872 into easybuilders:develop Aug 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants