Skip to content

add libtommath dependency to Tcl v9.0.1#23568

Merged
SebastianAchilles merged 3 commits intoeasybuilders:developfrom
Thyre:20250803220051_new_pr_Tcl901
Aug 4, 2025
Merged

add libtommath dependency to Tcl v9.0.1#23568
SebastianAchilles merged 3 commits intoeasybuilders:developfrom
Thyre:20250803220051_new_pr_Tcl901

Conversation

@Thyre
Copy link
Copy Markdown
Collaborator

@Thyre Thyre commented Aug 3, 2025

(created using eb --new-pr)

Tcl v9.0.1 seems to have libtommath as a new dependency, which can be pulled in from the system.
This lands as a dependency in the .pc files, and can cause building later packages to fail.

Prior versions seem to work fine, so no change needed there.

Requires:

@Thyre Thyre added bug fix 2025b issues & PRs related to 2025b common toolchains labels Aug 3, 2025
@github-actions github-actions Bot added the change label Aug 3, 2025
@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Aug 3, 2025

@boegelbot please test @ jsc-zen3

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Aug 3, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x AMD Navi 48 [Radeon RX 9070/9070 XT/9070 GRE] (device id: 0x7550, gfx: gfx1201, driver: 6.15.8-arch1-2), 1 x AMD Raphael (device id: 0x164e, gfx: gfx1036, driver: 6.15.8-arch1-2), Python 3.13.5
See https://gist.github.com/Thyre/a063454726f2a5dd329ebc5b9024dbf1 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23568 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23568 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7469

Test results coming soon (I hope)...

Details

- notification for comment with ID 3148666501 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Aug 3, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
ZAM054 - Linux Zorin OS 17, x86_64, 12th Gen Intel(R) Core(TM) i7-1260P, 1 x NVIDIA NVIDIA GeForce MX550, 570.133.07, Python 3.10.12
See https://gist.github.com/Thyre/916b337f4adf16aad6c67f70f90a37fa for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/d42fe366e3f340779b382af73d4c78a3 for a full test report.

Signed-off-by: Jan André Reuter <[email protected]>
@Thyre Thyre changed the title {lang}[GCCcore/14.3.0] Avoid libtommath system dep in Tcl v9.0.1 {lang}[GCCcore/14.3.0] Add libtommath dep to Tcl v9.0.1 Aug 3, 2025
@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Aug 3, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x AMD Navi 48 [Radeon RX 9070/9070 XT/9070 GRE] (device id: 0x7550, gfx: gfx1201, driver: 6.15.8-arch1-2), 1 x AMD Raphael (device id: 0x164e, gfx: gfx1036, driver: 6.15.8-arch1-2), Python 3.13.5
See https://gist.github.com/Thyre/4790f8c0bdfe6697835cd0b16379b85c for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Aug 3, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
ZAM054 - Linux Zorin OS 17, x86_64, 12th Gen Intel(R) Core(TM) i7-1260P, 1 x NVIDIA NVIDIA GeForce MX550, 570.133.07, Python 3.10.12
See https://gist.github.com/Thyre/0bd7b908631f05305eddb9afcc8e0d96 for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Aug 3, 2025

Using libtommath as a dependency here causes a circular dependency.
There's the option to build libtommath with a Makefile only, not using CMake. This would resolve the issue.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Aug 3, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x AMD Navi 48 [Radeon RX 9070/9070 XT/9070 GRE] (device id: 0x7550, gfx: gfx1201, driver: 6.15.8-arch1-2), 1 x AMD Raphael (device id: 0x164e, gfx: gfx1036, driver: 6.15.8-arch1-2), Python 3.13.5
See https://gist.github.com/Thyre/f34f94be859067703e1caef64135e05a for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Aug 3, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
ZAM054 - Linux Zorin OS 17, x86_64, 12th Gen Intel(R) Core(TM) i7-1260P, 1 x NVIDIA NVIDIA GeForce MX550, 570.133.07, Python 3.10.12
See https://gist.github.com/Thyre/f8ea6fa729441fc44e117f7319b4abdd for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Aug 4, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
datenlager - Linux Ubuntu 24.04, x86_64, AMD Ryzen 7 3700X 8-Core Processor, Python 3.12.3
See https://gist.github.com/Thyre/8f1077c33531671919313abed1faf13d for a full test report.

@SebastianAchilles SebastianAchilles added this to the release after 5.1.1 milestone Aug 4, 2025
@SebastianAchilles
Copy link
Copy Markdown
Member

Test report by @SebastianAchilles
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3867
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
skx-rockylinux-96 - Linux Rocky Linux 9.6 (Blue Onyx), x86_64, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz (skylake_avx512), 4 x NVIDIA Tesla V100-SXM2-32GB, 575.57.08, Python 3.9.21
See https://gist.github.com/SebastianAchilles/4dccb68aeb240735ae6abd01b57cac27 for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Aug 4, 2025

@boegelbot please test @ jsc-zen3

@SebastianAchilles
Copy link
Copy Markdown
Member

Test report by @SebastianAchilles
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3867
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bwd-rockylinux-100 - Linux Rocky Linux 10.0 (Red Quartz), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), 2 x NVIDIA NVIDIA GeForce GTX 1060 6GB, 535.247.01, Python 3.12.9
See https://gist.github.com/SebastianAchilles/cad5ce123b1f0b7d8994978cf9d7ad22 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23568 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23568 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7474

Test results coming soon (I hope)...

Details

- notification for comment with ID 3149527897 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/44dee44095739c0e466ae2a73941e350 for a full test report.

Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

Going in, thanks @Thyre!

@SebastianAchilles SebastianAchilles merged commit 7016cf5 into easybuilders:develop Aug 4, 2025
8 checks passed
@boegel boegel changed the title {lang}[GCCcore/14.3.0] Add libtommath dep to Tcl v9.0.1 add libtommath dependency to Tcl v9.0.1 Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2025b issues & PRs related to 2025b common toolchains bug fix change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants