Skip to content

Remove max_failed_tests in PyTorch easyconfigs where the used value was less or equal to the default#23577

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:pt-test-fails
Aug 12, 2025
Merged

Remove max_failed_tests in PyTorch easyconfigs where the used value was less or equal to the default#23577
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:pt-test-fails

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Aug 5, 2025

@github-actions github-actions Bot added the change label Aug 5, 2025
@boegel boegel changed the title Remove max_failed_tests in PyTorch ECs where the used value was less or equal to the default Remove max_failed_tests in PyTorch easyconfigs where the used value was less or equal to the default Aug 12, 2025
@boegel boegel added this to the next release (5.1.2) milestone Aug 12, 2025
@boegel boegel changed the title Remove max_failed_tests in PyTorch easyconfigs where the used value was less or equal to the default Remove max_failed_tests in PyTorch easyconfigs where the used value was less or equal to the default Aug 12, 2025
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, makes sense since custom easyblock for PyTorch has been updated to allow max. 10 failing tests (see easybuilders/easybuild-easyblocks#3869)

@boegel boegel merged commit 6ce1077 into easybuilders:develop Aug 12, 2025
8 checks passed
@Flamefire Flamefire deleted the pt-test-fails branch August 13, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants