Skip to content

add patch for dask v2024.9.1 to fix incorrect indexing with boolean arrays#23634

Merged
Crivella merged 1 commit intoeasybuilders:developfrom
smoors:20250811174637_new_pr_dask202491
Sep 3, 2025
Merged

add patch for dask v2024.9.1 to fix incorrect indexing with boolean arrays#23634
Crivella merged 1 commit intoeasybuilders:developfrom
smoors:20250811174637_new_pr_dask202491

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Aug 11, 2025

(created using eb --new-pr)

@smoors smoors changed the title fix incorrect boolean indexing with boolean arrays for dask v2024.0.1 fix incorrect indexing with boolean arrays for dask v2024.0.1 Aug 11, 2025
@smoors smoors changed the title fix incorrect indexing with boolean arrays for dask v2024.0.1 fix incorrect indexing with boolean arrays for dask v2024.9.1 Aug 11, 2025
@smoors smoors added bug fix and removed change labels Aug 11, 2025
@smoors smoors added this to the next release (5.1.2) milestone Aug 11, 2025
@smoors smoors mentioned this pull request Aug 11, 2025
Merged
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Aug 11, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 11, 2025

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23634 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23634 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7542

Test results coming soon (I hope)...

Details

- notification for comment with ID 3176332462 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 11, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/e6999f0642ad5733eb1d97c99bf6fd79 for a full test report.

@Thyre Thyre added the 2024a issues & PRs related to 2024a common toolchains label Aug 12, 2025
@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Sep 3, 2025

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/144c159e870ee3e7fab4665a56126080 for a full test report.

Crivella
Crivella approved these changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Crivella Crivella left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

also manually checked the additional test added to the codebase testsuite in

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Sep 3, 2025

Going in, thanks @smoors!

@Crivella Crivella merged commit 7d7deeb into easybuilders:develop Sep 3, 2025
8 checks passed
@boegel boegel changed the title fix incorrect indexing with boolean arrays for dask v2024.9.1 add patch for dask v2024.9.1 to fix incorrect indexing with boolean arrays Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Crivella Crivella Crivella approved these changes

Assignees

No one assigned

Labels

2024a issues & PRs related to 2024a common toolchains bug fix

Projects

None yet

Milestone

5.1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@smoors @boegelbot @Crivella @Thyre