Skip to content

Remove extensions that were added multiple times#23806

Merged
Crivella merged 7 commits intoeasybuilders:developfrom
Flamefire:remove-dup-exts
Oct 29, 2025
Merged

Remove extensions that were added multiple times#23806
Crivella merged 7 commits intoeasybuilders:developfrom
Flamefire:remove-dup-exts

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Sep 5, 2025

Companion to the CI checks: #23802 and previous PR #23801 which is only for PYPI-bundle

Quiskit requires

R-bundle-Bioconductor-3.18-foss-2023a-R-4.3.2.eb requires RCurl, recently added to R-bundle-CRAN

@Flamefire Flamefire changed the title Remove dup exts Remove extensions added multiple times Sep 5, 2025
@github-actions github-actions Bot added the change label Sep 5, 2025
@Crivella Crivella added bug fix and removed change labels Sep 5, 2025
@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Sep 5, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr-23806"

@boegelbot
Copy link
Copy Markdown
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23806 EB_ARGS="--installpath /tmp/$USER/pr-23806" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23806 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7870

Test results coming soon (I hope)...

Details

- notification for comment with ID 3258490070 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 27 out of 33 (22 easyconfigs in total)
jsczen3c4.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/7c8c06f8c8283d7cf50122b65fa7d8e6 for a full test report.

Comment thread easybuild/easyconfigs/c/Cellformer/Cellformer-20240917-foss-2023a-R-4.3.2.eb Outdated
@github-actions github-actions Bot added the change label Sep 7, 2025
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 7, 2025

Symengine fails with at static char altStackMem[SIGSTKSZ]; due to SIGSTKSZ no longer being a macro in glibc(?), see symengine/symengine#1878
So we'd need something similar to https://github.com/easybuilders/easybuild-easyconfigs/blob/c489f47c62900ffb78ff0d04dcc3a78dd1bd2512/easybuild/easyconfigs/l/Libint/Libint-2.7.2_update-catch-hpp-fix-MINSIGSTKSZ.patch or replace it by e.g. static char altStackMem = malloc(std::max<size_t>(SIGSTKSZ, 32*1024)) which is more or less the essence

--> #23817

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Sep 9, 2025

Symengine fails with at static char altStackMem[SIGSTKSZ]; due to SIGSTKSZ no longer being a macro in glibc(?), see symengine/symengine#1878

I think the error is as described, but the linked issue showcases a different one.

I've added a possibly different solution on the other pr #23817

@boegel boegel added this to the release after 5.1.2 (5.2.0?) milestone Sep 10, 2025
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 15, 2025

I've added a possibly different solution on the other pr #23817

As this is merged can you retry this PR?

@Crivella
Copy link
Copy Markdown
Contributor

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr-23806"

@boegelbot
Copy link
Copy Markdown
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23806 EB_ARGS="--installpath /tmp/$USER/pr-23806" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23806 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7961

Test results coming soon (I hope)...

Details

- notification for comment with ID 3292857963 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 32 out of 33 (22 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/581677587bfd1028182933ecda74e2b6 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 17, 2025

Qiskit-0.31.0-foss-2021a.eb fails with:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
 Compatibility with CMake < 3.5 has been removed from CMake.

That seems unrelated to this PR and I'm wondering how that went undetected so far
I don't see where 3.5 is coming from. It isn't in the source on GitHub

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Sep 17, 2025

Qiskit-0.31.0-foss-2021a.eb fails with:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
 Compatibility with CMake < 3.5 has been removed from CMake.

That seems unrelated to this PR and I'm wondering how that went undetected so far I don't see where 3.5 is coming from. It isn't in the source on GitHub

It seems to pull in CMake 4.0 from somewhere, and then probably fails for some other component (which it maybe pulls in as well?)

@Crivella
Copy link
Copy Markdown
Contributor

Not sure how worth it is to dig into this since 2021a is deprecated.
I am wondering if we should just make an update of Qskit to a newer toolchain just to keep the logic of the EC in and move it to the archived repo

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Sep 17, 2025

Not sure how worth it is to dig into this since 2021a is deprecated. I am wondering if we should just make an update of Qskit to a newer toolchain just to keep the logic of the EC in and move it to the archived repo

I mean if we can find a fix for this, great. But I wouldn't block this PR because of this.

@Flamefire
Copy link
Copy Markdown
Contributor Author

It is actually a larger issue that might affect more packages, in particular most of those using skikit-build: It doesn't use our CMake but downloads a pip package with that using the latest version. The "3.5" is something internal from skikit-build and since CMake 4.0 this causes an error.

The fix is in #23895 which should at least avoid the error when it decides to use CMake 4

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 23, 2025

Test report by @Flamefire
FAILED
Build succeeded for 20 out of 22 (22 easyconfigs in total)
n1715 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (sapphirerapids), Python 3.9.18
See https://gist.github.com/Flamefire/bb284f446981fa394a4aeb3fd31e0391 for a full test report.

Temporary filesystem issue. Rebuild:

== Build succeeded for 2 out of 2
== Summary:
   * [SUCCESS] Perl/5.34.1-GCCcore-11.3.0
   * [SUCCESS] Perl/5.36.0-GCCcore-12.1.0

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 23, 2025

Test report by @Flamefire
FAILED
Build succeeded for 40 out of 44 (22 easyconfigs in total)
i8005 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7352 24-Core Processor (zen2), 8 x NVIDIA NVIDIA A100-SXM4-40GB, 580.65.06, Python 3.9.21
See https://gist.github.com/Flamefire/9d12bcc39f36ff862f6841d3c526c6c8 for a full test report.

Can be considered SUCCESS:
Missing RCurl in R-bundle-CRAN-2023.12-foss-2023a.eb

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 22 out of 22 (22 easyconfigs in total)
c144 - Linux AlmaLinux 9.4, x86_64, AMD EPYC 9334 32-Core Processor (zen4), 4 x NVIDIA NVIDIA H100, 560.35.03, Python 3.9.18
See https://gist.github.com/Flamefire/20c5daa0f607e8903eaafebb612a273a for a full test report.

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Oct 7, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr-23806"

@boegelbot
Copy link
Copy Markdown
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23806 EB_ARGS="--installpath /tmp/$USER/pr-23806" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23806 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8193

Test results coming soon (I hope)...

Details

- notification for comment with ID 3377328598 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 32 out of 33 (22 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/9439e841a9673a8d99e9d2a5813c3068 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @boegelbot FAILED Build succeeded for 32 out of 33 (22 easyconfigs in total) jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21 See https://gist.github.com/boegelbot/9439e841a9673a8d99e9d2a5813c3068 for a full test report.

@Crivella The single failure (Quiskit) is due to requiring the fix for scikit-build: #23895 So the PR should be fine.

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Oct 9, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="scikit-build-0.11.1-GCCcore-10.3.0.eb Qiskit-0.31.0-foss-2021a.eb --installpath=/tmp/$USER/ecpr-23806"

@boegelbot
Copy link
Copy Markdown
Collaborator

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23806 EB_ARGS="scikit-build-0.11.1-GCCcore-10.3.0.eb Qiskit-0.31.0-foss-2021a.eb --installpath=/tmp/$USER/ecpr-23806" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23806 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8235

Test results coming soon (I hope)...

Details

- notification for comment with ID 3384436006 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Oct 9, 2025

@Crivella The single failure (Quiskit) is due to requiring the fix for scikit-build: #23895 So the PR should be fine.

Yeah forgot to add a rebuild for it i see @Thyre already launched it

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 11 out of 12 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/828429bad140489abc4ab62841d5257e for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Hm, broken numba package or parallel installation modifying it?

failing sanity check for 'sparse' extension: command "/project/def-maintainers/boegelbot/rocky9/zen3/software/Python/3.9.5-GCCcore-10.3.0/bin/python -c "import sparse"" failed; output:
...
OSError: Could not load shared object file: libllvmlite.so

@Flamefire
Copy link
Copy Markdown
Contributor Author

@Crivella Can we merge this? I'd like to get #23802 merged ASAP to avoid this issue getting reintroduced by new PRs

@Crivella
Copy link
Copy Markdown
Contributor

Agree the Qskit/numba failure is not really related to this and happening on a non-supported TC so i would not block this

Copy link
Copy Markdown
Contributor

@Crivella Crivella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Crivella Crivella removed the change label Oct 29, 2025
@Crivella
Copy link
Copy Markdown
Contributor

Going in, thanks @Flamefire!

@Crivella Crivella merged commit 418a4d0 into easybuilders:develop Oct 29, 2025
8 checks passed
@Flamefire Flamefire deleted the remove-dup-exts branch October 29, 2025 09:20
@boegel boegel changed the title Remove extensions added multiple times Remove extensions that were added multiple times Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants