Skip to content

{lib}[foss/2024a] heat v1.6.0#23857

Merged
jfgrimm merged 16 commits intoeasybuilders:developfrom
ClaudiaComito:20250912184515_new_pr_heat160
Sep 17, 2025
Merged

{lib}[foss/2024a] heat v1.6.0#23857
jfgrimm merged 16 commits intoeasybuilders:developfrom
ClaudiaComito:20250912184515_new_pr_heat160

Conversation

@ClaudiaComito
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

…a.eb and patches: heat-1.6.0-license-fix.patch
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 12, 2025

Updated software heat-1.6.0-gompi-2024a.eb

Diff against heat-1.6.0-gpsmpi-2024a.eb

easybuild/easyconfigs/h/heat/heat-1.6.0-gpsmpi-2024a.eb

diff --git a/easybuild/easyconfigs/h/heat/heat-1.6.0-gpsmpi-2024a.eb b/easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb
index 22ddd29bff..129e6a3b00 100644
--- a/easybuild/easyconfigs/h/heat/heat-1.6.0-gpsmpi-2024a.eb
+++ b/easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb
@@ -9,12 +9,11 @@ Heat builds on PyTorch and mpi4py to provide high-performance computing infrastr
 memory-intensive applications within the NumPy/SciPy ecosystem.
 """
 
-toolchain = {'name': 'gpsmpi', 'version': '2024a'}
+toolchain = {'name': 'foss', 'version': '2024a'}
 
 source_urls = ['https://pypi.python.org/packages/source/h/%(name)s']
 sources = [SOURCELOWER_TAR_GZ]
 patches = ['heat-1.6.0-license-fix.patch']
-
 checksums = [
     {'%(name)s-%(version)s.tar.gz': 'cd011e67c284b7f94d0f1c6ff8bf5309535fa26a895b0db2df83290c47dae55b'},
     {'heat-1.6.0-license-fix.patch': 'fd45ba7e5761209f6a7e0fbd28dabf5b82fb1e0db78e3fa1596de2f4df2bf016'},
@@ -22,17 +21,13 @@ checksums = [
 
 dependencies = [
     ('Python', '3.12.3'),
-    ('PyTorch', '2.5.1', '', ('gcccoreflexiblas', '13.3.0-3.4.4')),
-    ('torchvision', '0.20.1', '', ('gcccoreflexiblas', '13.3.0-3.4.4')),
-    ('SciPy-bundle', '2024.05', '', ('gcccoreflexiblas', '13.3.0-3.4.4')),
+    ('PyTorch', '2.6.0'),
+    ('torchvision', '0.21.0'),
+    ('SciPy-bundle', '2024.05'),
     ('Pillow-SIMD', '10.4.0'),
     ('mpi4py', '4.0.1'),
 ]
 
-use_pip = True
-sanity_pip_check = True
-
-download_dep_fail = True
 
 sanity_check_paths = {
     'files': [],

Updated software heat-1.6.0-gpsmpi-2024a.eb

Diff against heat-1.6.0-gompi-2024a.eb

easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb

diff --git a/easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb b/easybuild/easyconfigs/h/heat/heat-1.6.0-gpsmpi-2024a.eb
index 129e6a3b00..22ddd29bff 100644
--- a/easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb
+++ b/easybuild/easyconfigs/h/heat/heat-1.6.0-gpsmpi-2024a.eb
@@ -9,11 +9,12 @@ Heat builds on PyTorch and mpi4py to provide high-performance computing infrastr
 memory-intensive applications within the NumPy/SciPy ecosystem.
 """
 
-toolchain = {'name': 'foss', 'version': '2024a'}
+toolchain = {'name': 'gpsmpi', 'version': '2024a'}
 
 source_urls = ['https://pypi.python.org/packages/source/h/%(name)s']
 sources = [SOURCELOWER_TAR_GZ]
 patches = ['heat-1.6.0-license-fix.patch']
+
 checksums = [
     {'%(name)s-%(version)s.tar.gz': 'cd011e67c284b7f94d0f1c6ff8bf5309535fa26a895b0db2df83290c47dae55b'},
     {'heat-1.6.0-license-fix.patch': 'fd45ba7e5761209f6a7e0fbd28dabf5b82fb1e0db78e3fa1596de2f4df2bf016'},
@@ -21,13 +22,17 @@ checksums = [
 
 dependencies = [
     ('Python', '3.12.3'),
-    ('PyTorch', '2.6.0'),
-    ('torchvision', '0.21.0'),
-    ('SciPy-bundle', '2024.05'),
+    ('PyTorch', '2.5.1', '', ('gcccoreflexiblas', '13.3.0-3.4.4')),
+    ('torchvision', '0.20.1', '', ('gcccoreflexiblas', '13.3.0-3.4.4')),
+    ('SciPy-bundle', '2024.05', '', ('gcccoreflexiblas', '13.3.0-3.4.4')),
     ('Pillow-SIMD', '10.4.0'),
     ('mpi4py', '4.0.1'),
 ]
 
+use_pip = True
+sanity_pip_check = True
+
+download_dep_fail = True
 
 sanity_check_paths = {
     'files': [],

@Thyre Thyre added the 2024a issues & PRs related to 2024a common toolchains label Sep 12, 2025
@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Sep 12, 2025

Thanks for trying to upstream the EasyConfig 😄
There are a few differences from what we have at JSC and how e.g. toolchains are handled here. I'll take a quick look later.

@ClaudiaComito
Copy link
Copy Markdown
Contributor Author

ClaudiaComito commented Sep 12, 2025

Thanks for trying to upstream the EasyConfig 😄 There are a few differences from what we have at JSC and how e.g. toolchains are handled here. I'll take a quick look later.

Thanks for the "trying" 😂 and thanks for all the help @Thyre !

Comment thread easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb Outdated
Comment thread easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb Outdated
Comment thread easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb Outdated
Comment thread easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb Outdated
Comment thread easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb Outdated
Comment thread easybuild/easyconfigs/h/heat/heat-1.6.0-gpsmpi-2024a.eb Outdated
Comment thread easybuild/easyconfigs/h/heat/heat-1.6.0-license-fix.patch
@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Sep 12, 2025

Thanks for the "trying" 😂 and thanks for all the help @Thyre !

I didn't want to be harsh or anything. I'm genuinely happy when people from JSC bring some of our efforts we do at our software stage back here, since that benefits everyone 😀

@ClaudiaComito
Copy link
Copy Markdown
Contributor Author

Thanks for the "trying" 😂 and thanks for all the help @Thyre !

I didn't want to be harsh or anything. I'm genuinely happy when people from JSC bring some of our efforts we do at our software stage back here, since that benefits everyone 😀

You weren't harsh at all, I genuinely laughed! you've been a huge help all day. I learned so much on easyconfigs this week, that I thought I better ship this one upstream now, before I forget everything.

I'll fix the PR on Monday... or at least try :) Thanks again, have a great weekend!

@github-actions github-actions Bot added new and removed update labels Sep 15, 2025
@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Sep 15, 2025

@boegelbot please test @ jsc-zen3

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Sep 15, 2025

@ClaudiaComito Can you rename the PR to reflect the changes? {lib}[foss/2024a] heat v1.6.0 should be correct 😄

Looks good to me otherwise, lets see if the test build works.

@boegelbot
Copy link
Copy Markdown
Collaborator

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23857 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23857 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7946

Test results coming soon (I hope)...

Details

- notification for comment with ID 3291004613 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/6c15cacb34969bd7645c8367f483ccbd for a full test report.

@ClaudiaComito ClaudiaComito changed the title {lib}[gompi/2024a,gpsmpi/2024a] heat v1.6.0 {lib}[foss/2024a] heat v1.6.0 Sep 15, 2025
@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Sep 15, 2025

@ClaudiaComito, you'll need to rename the EasyConfig for the new toolchain as well:

 AssertionError: 'heat-1.6.0-gompi-2024a.eb' != 'heat-1.6.0-foss-2024a.eb'
- heat-1.6.0-gompi-2024a.eb
?            ^ ^^^
+ heat-1.6.0-foss-2024a.eb
?            ^ ^^
 : Filename '/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/h/heat/heat-1.6.0-gompi-2024a.eb' of parsed easyconfig matches expected filename 'heat-1.6.0-foss-2024a.eb'

Comment thread easybuild/easyconfigs/h/heat/heat-1.6.0-foss-2024a.eb
@jfgrimm jfgrimm added this to the 5.x milestone Sep 15, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/30d318f97bc5ad240eda3e352629002d for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Sep 15, 2025

== 2025-09-15 10:01:19,669 build_log.py:226 ERROR EasyBuild encountered an error (at easybuild/easybuild-framework/easybuild/base/exceptions.py:126 in __init__): `/project/def-maintainers/boegelbot/rocky9/zen3/software/Python/3.12.3-GCCcore-13.3.0/bin/python -m pip check` failed:
heat 1.6.0 has requirement scipy~=1.14, but you have scipy 1.13.1.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Sep 17, 2025

@ClaudiaComito do you know if heat actually requires scipy v1.14, or can we get away with using v1.13.1 (which is the version we have in SciPy-bundle for this toolchain generation)?

@ClaudiaComito
Copy link
Copy Markdown
Contributor Author

@ClaudiaComito do you know if heat actually requires scipy v1.14, or can we get away with using v1.13.1 (which is the version we have in SciPy-bundle for this toolchain generation)?

Hi @jfgrimm, sorry for the delay. I'm pretty sure Scipy 1.13 will be fine. What's the best way to fix it? One more patch? Thanks!

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Sep 17, 2025

A patch like this (as an example) would work, or one could simply sed the version. I think a patch would be the safer option.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Sep 17, 2025

indeed, either of the following is fine:

  • a patch to the pyproject.toml
  • a sed command, e.g. preinstallopts = "sed -i 's/scipy~=1.14/scipy>1.13/g' pyproject.toml &&"

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Sep 17, 2025

@boegelbot please test @ jsc-zen3

@jfgrimm jfgrimm dismissed their stale review September 17, 2025 15:28

req. changes made

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23857 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23857 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7972

Test results coming soon (I hope)...

Details

- notification for comment with ID 3303537890 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/130fbb463d704c9c1bd33bf7d02ac869 for a full test report.

@ClaudiaComito
Copy link
Copy Markdown
Contributor Author

Test report by @boegelbot FAILED Build succeeded for 0 out of 1 (1 easyconfigs in total) jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21 See https://gist.github.com/boegelbot/130fbb463d704c9c1bd33bf7d02ac869 for a full test report.

In principle Heat 1.6 no longer supports python 3.9. But I suppose if the available pytorch version supports python 3.9, I can put in another patch

Comment thread easybuild/easyconfigs/h/heat/heat-1.6.0-scipy-version.patch Outdated
Comment thread easybuild/easyconfigs/h/heat/heat-1.6.0-foss-2024a.eb Outdated
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Sep 17, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23857 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23857 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7973

Test results coming soon (I hope)...

Details

- notification for comment with ID 3303601771 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/02f5300864b9fd06dbddd06656414385 for a full test report.

Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for the contribution @ClaudiaComito (and @Thyre)

@jfgrimm jfgrimm enabled auto-merge September 17, 2025 15:55
@jfgrimm jfgrimm merged commit c24fbf8 into easybuilders:develop Sep 17, 2025
8 checks passed
@ClaudiaComito ClaudiaComito deleted the 20250912184515_new_pr_heat160 branch September 18, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2024a issues & PRs related to 2024a common toolchains new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants