Skip to content

disable building of documentation for Waylandpp#23968

Merged
boegel merged 2 commits intoeasybuilders:developfrom
TopRichard:Waylandpp-1.0.0-build-dependencies
Sep 23, 2025
Merged

disable building of documentation for Waylandpp#23968
boegel merged 2 commits intoeasybuilders:developfrom
TopRichard:Waylandpp-1.0.0-build-dependencies

Conversation

@TopRichard
Copy link
Copy Markdown
Contributor

@TopRichard TopRichard commented Sep 23, 2025

No description provided.

@Thyre Thyre added 2021b issues & PRs related to 2021b 2023a 2022a labels Sep 23, 2025
Micket
Micket previously requested changes Sep 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please instead just disable the docs, as these are useless (noone on a cluster will ever look up docs for Waylandpp, nor would they ever find these html pages if they did need it, and html pages over what is often a ssh session aren't a good way of viewing the docs anyway).

configopts = '-DBUILD_DOCUMENTATION=OFF '

@bedroge bedroge changed the title add missing build-deps for Waylandpp don't build the Waylandpp documentation Sep 23, 2025
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Sep 23, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 23, 2025

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23968 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23968 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8039

Test results coming soon (I hope)...

Details

- notification for comment with ID 3324156573 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 23, 2025

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/dc89d8c9edf2b33b98ef50f5ee6140b8 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 23, 2025

I've reinstated the LLVM/12.0.1-GCCcore-11.2.0 module that went missing, trying again...

@boegel boegel added this to the next release (5.1.2) milestone Sep 23, 2025
boegel
boegel approved these changes Sep 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title don't build the Waylandpp documentation disable building of documentation for Waylandpp Sep 23, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 23, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 23, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23968 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23968 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8046

Test results coming soon (I hope)...

Details

- notification for comment with ID 3325302276 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 23, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/83a2e7a47c905797b2c03b9c1522ed17 for a full test report.

@boegel boegel dismissed Micket’s stale review September 23, 2025 20:50

requested change made

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 23, 2025

Going in, thanks @TopRichard!

@boegel boegel merged commit 3e33716 into easybuilders:develop Sep 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@Micket Micket Micket left review comments

Assignees

No one assigned

Labels

2021b issues & PRs related to 2021b 2022a 2023a change

Projects

None yet

Milestone

5.1.2

Development

Successfully merging this pull request may close these issues.

6 participants

@TopRichard @bedroge @boegelbot @boegel @Micket @Thyre