Skip to content

switch source URL + add preconfigopts to generate configure script in easyconfigs for ABINIT v9.6.2#24153

Merged
SebastianAchilles merged 6 commits intoeasybuilders:developfrom
branfosj:20251008114133_new_pr_ABINIT962
Oct 9, 2025
Merged

switch source URL + add preconfigopts to generate configure script in easyconfigs for ABINIT v9.6.2#24153
SebastianAchilles merged 6 commits intoeasybuilders:developfrom
branfosj:20251008114133_new_pr_ABINIT962

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Oct 8, 2025 •
edited
Loading

(created using eb --new-pr)

The sources are not available and I cannot find an alternative for them. This switches to the GitHub release version and then uses the provided script to generate the configure file.

@github-actions github-actions Bot added the change label Oct 8, 2025
@branfosj branfosj added bug fix and removed change labels Oct 8, 2025
@branfosj branfosj added this to the next release (5.2.0?) milestone Oct 8, 2025
@branfosj branfosj marked this pull request as draft October 8, 2025 11:02
@Thyre Thyre added 2021a 2021b issues & PRs related to 2021b 2022a labels Oct 8, 2025
@branfosj branfosj marked this pull request as ready for review October 8, 2025 11:19
@github-actions github-actions Bot added the change label Oct 8, 2025
@branfosj branfosj removed the change label Oct 8, 2025
Micket
Micket previously approved these changes Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 8, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 7 out of 7 (4 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/7090ab5259d3ee661b3590b434d0f508 for a full test report.

SebastianAchilles
SebastianAchilles reviewed Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a minimal container I am getting:

[makemake] WARNING: invalid version number '' set to 0
[makemake] Error: M4 is too old (0) - please install v1.4.8 or above
makemake: Aborting now

and the same for autoconf. Adding the builddependencies solved this problem.

Comment thread easybuild/easyconfigs/a/ABINIT/ABINIT-9.6.2-foss-2022a.eb
Comment thread easybuild/easyconfigs/a/ABINIT/ABINIT-9.6.2-intel-2021a.eb
Comment thread easybuild/easyconfigs/a/ABINIT/ABINIT-9.6.2-intel-2021b.eb
Comment thread easybuild/easyconfigs/a/ABINIT/ABINIT-9.6.2-intel-2022a.eb
@branfosj @SebastianAchilles
add M4/Autotools
833c81b 
Co-authored-by: SebastianAchilles <[email protected]>
branfosj and others added 3 commits October 8, 2025 14:57
@branfosj @SebastianAchilles
add M4/Autotools
aeeccdc 
Co-authored-by: SebastianAchilles <[email protected]>
@branfosj @SebastianAchilles
add M4/Autotools
b0f94e8 
Co-authored-by: SebastianAchilles <[email protected]>
@branfosj @SebastianAchilles
add M4/Autotools
853e1fe 
Co-authored-by: SebastianAchilles <[email protected]>
@github-actions github-actions Bot added the change label Oct 8, 2025
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 8, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/25df8c577710e3b2d820c4f3d51ec57d for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 9, 2025

Going in, thanks @branfosj!

@SebastianAchilles SebastianAchilles merged commit 8cb8f31 into easybuilders:develop Oct 9, 2025
8 checks passed
@branfosj branfosj deleted the 20251008114133_new_pr_ABINIT962 branch October 9, 2025 10:09
@boegel boegel changed the title switch download source and add preconfigopts to generate configure in ABINIT/9.6.2 switch source URL + add preconfigopts to generate configure script in easyconfigs for ABINIT v9.6.2 Dec 19, 2025
@boegel boegel removed the change label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

@Micket Micket Micket left review comments

Assignees

No one assigned

Labels

2021a 2021b issues & PRs related to 2021b 2022a bug fix

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@branfosj @SebastianAchilles @Micket @boegel @Thyre