Skip to content

switch source URL + add preconfigopts to generate configure script in easyconfigs for ABINIT v9.4.2#24155

Merged
SebastianAchilles merged 3 commits intoeasybuilders:developfrom
branfosj:20251008122232_new_pr_ABINIT942
Oct 9, 2025
Merged

switch source URL + add preconfigopts to generate configure script in easyconfigs for ABINIT v9.4.2#24155
SebastianAchilles merged 3 commits intoeasybuilders:developfrom
branfosj:20251008122232_new_pr_ABINIT942

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Oct 8, 2025

(created using eb --new-pr)

@branfosj branfosj mentioned this pull request Oct 8, 2025
Closed
@branfosj branfosj added this to the next release (5.2.0?) milestone Oct 8, 2025
@github-actions github-actions Bot added the change label Oct 8, 2025
@branfosj branfosj removed the change label Oct 8, 2025
Micket
Micket previously approved these changes Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 8, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/1d49b11f0de6778e5d0e6654f79e60a9 for a full test report.

SebastianAchilles
SebastianAchilles reviewed Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a minimal container I am getting:

[makemake] WARNING: invalid version number '' set to 0
[makemake] Error: M4 is too old (0) - please install v1.4.8 or above
makemake: Aborting now

and the same for autoconf. Adding the builddependencies solved this problem.

Comment thread easybuild/easyconfigs/a/ABINIT/ABINIT-9.4.2-foss-2021a.eb
Comment thread easybuild/easyconfigs/a/ABINIT/ABINIT-9.4.2-intel-2021a.eb
@branfosj @SebastianAchilles
add M4/Autotools
c3019a5 
Co-authored-by: SebastianAchilles <[email protected]>
@branfosj @SebastianAchilles
add M4/Autotools
7f7edef 
Co-authored-by: SebastianAchilles <[email protected]>
@github-actions github-actions Bot added the change label Oct 8, 2025
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 8, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/9068faf18b1a3e66febee108554754cc for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 8, 2025

Going in, thanks @branfosj!

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 8, 2025

@SebastianAchilles merge is broken for you? This didn't actually get merged.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 9, 2025

@SebastianAchilles merge is broken for you? This didn't actually get merged.

Yes, it didn't work yesterday. Manually merging didn't work either. Let me try again.

@SebastianAchilles SebastianAchilles merged commit 7537eef into easybuilders:develop Oct 9, 2025
8 checks passed
@boegel boegel changed the title switch download source and add preconfigopts to generate configure in ABINIT/9.4.2 switch source URL + add preconfigopts to generate configure script in easyconfigs for ABINIT v9.4.2 Dec 19, 2025
@boegel boegel removed the change label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

@Micket Micket Micket left review comments

Assignees

No one assigned

Labels

2021a bug fix

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@branfosj @SebastianAchilles @Micket @boegel