{base}[GCCcore/13.3.0] isONclust3 v0.3.0#24175
Conversation
| ("heck", "0.4.1"), | ||
| ("heck", "0.5.0"), | ||
| ("indexmap", "2.6.0"), | ||
| (name, version), |
There was a problem hiding this comment.
is the software also shipped in a crate? If so, then you don't need the github thing at all. You can remove sources and source_urls completely.
Also, for some consistency, could you please move crates block up to before checksums (where sources is)
There was a problem hiding this comment.
is the software also shipped in a crate? If so, then you don't need the github thing at all. You can remove sources and source_urls completely.
When I remove the sources entry, the build fails with errors like
error: no matching package found
searched package name: `log`
perhaps you meant: bio, bv, clap, ...
location searched: registry `crates-io`
I know too little about crates to solve that.
Also, for some consistency, could you please move crates block up to before checksums (where sources is)
Done in 384a1aa. If that is the desired ordering, then perhaps eb --inject-checksums should do this automatically?
Micket
left a comment
There was a problem hiding this comment.
diff looks big, but i'm just reodering things.
The issue is that Cargo easyblock will enter the first source as the main thing to build; and your workaround by adding the isONClust3 sources twice just made it be the first source and correctly build it. Instead, the pattern we follow when the softwar exist as a crate itself is just to put the main software as the top crate.
checksums get reordered to match
|
@boegelbot please test @ jsc-zen3 |
|
Test report by @Micket |
|
@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3555169096 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
(created using
eb --new-pr)