Skip to content

add -Wno-error=int-conversion as extra C compiler flag for BLIS 1.1, to fix build on A64FX#24205

Merged
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20251011133609_new_pr_BLIS11
Oct 11, 2025
Merged

add -Wno-error=int-conversion as extra C compiler flag for BLIS 1.1, to fix build on A64FX#24205
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20251011133609_new_pr_BLIS11

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 11, 2025 •
edited
Loading

(created using eb --new-pr)

fix for:

kernels/armsve/1m/bli_dpackm_armsve512_asm_10xk.c: In function ‘bli_dpackm_armsve512_asm_10xk’:
kernels/armsve/1m/bli_dpackm_armsve512_asm_10xk.c:71:15: error: assignment to ‘void *’ from ‘long unsigned int’ makes pointer from integer without a cast [-Wint-conversion]
   71 |             p = ( (uint64_t)0x1 << 56 ) | (uint64_t)p;
      |               ^
compilation terminated due to -Wfatal-errors.
make: *** [Makefile:726: obj/a64fx/kernels/armsve/1m/bli_dpackm_armsve512_asm_10xk.o] Error 1
make: *** Waiting for unfinished jobs....
kernels/armsve/1m/bli_dpackm_armsve512_asm_16xk.c: In function ‘bli_dpackm_armsve512_asm_16xk’:
kernels/armsve/1m/bli_dpackm_armsve512_asm_16xk.c:70:15: error: assignment to ‘void *’ from ‘long unsigned int’ makes pointer from integer without a cast [-Wint-conversion]
   70 |             p = ( (uint64_t)0x1 << 56 ) | (uint64_t)p;
      |               ^
compilation terminated due to -Wfatal-errors.
make: *** [Makefile:726: obj/a64fx/kernels/armsve/1m/bli_dpackm_armsve512_asm_16xk.o] Error 1

see also https://gcc.gnu.org/gcc-14/porting_to.html#int-conversion

@boegel boegel changed the title add -Wno-error=int-conversion as extra C compiler flag for BLIS 1.1, to fix build on A64FX add -Wno-error=int-conversion as extra C compiler flag for BLIS 1.1, to fix build on A64FX Oct 11, 2025
@boegel boegel added bug fix EESSI Related to EESSI project aarch64 Related to Arm 64-bit (aarch64) and removed change labels Oct 11, 2025
@boegel boegel added this to the next release (5.2.0?) milestone Oct 11, 2025
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 11, 2025

@boegelbot please test @ jsc-zen3

@boegel boegel mentioned this pull request Oct 11, 2025
Merged
@boegel boegel requested a review from bedroge October 11, 2025 11:42
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 11, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24205 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24205 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8294

Test results coming soon (I hope)...

Details

- notification for comment with ID 3393229042 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 11, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cna0007.deucalion.macc.fccn.pt - Linux Rocky Linux 8.5, AArch64, UNKNOWN (a64fx), Python 3.13.4
See https://gist.github.com/boegel/81fac8e6834ce1f92958f83de53cad44 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 11, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/3cf64eaa7729069cb1e6f45219a822aa for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 11, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3533.doduo.os - Linux RHEL 9.6, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/boegel/765520c18af4b85041cc262ab79c5dd0 for a full test report.

@Thyre Thyre added the 2025a issues & PRs related to 2025a common toolchains label Oct 11, 2025
Micket
Micket approved these changes Oct 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 96da510 into easybuilders:develop Oct 11, 2025
8 checks passed
@boegel boegel deleted the 20251011133609_new_pr_BLIS11 branch October 11, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

@bedroge bedroge Awaiting requested review from bedroge

Assignees

No one assigned

Labels

2025a issues & PRs related to 2025a common toolchains aarch64 Related to Arm 64-bit (aarch64) bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @boegelbot @Micket @Thyre