Skip to content

symlink generic libraries for Tcl and Tk 9.0.1 for better library support#24213

Merged
Micket merged 7 commits intoeasybuilders:developfrom
Thyre:20251012010339_new_pr_Tcl901
Oct 12, 2025
Merged

symlink generic libraries for Tcl and Tk 9.0.1 for better library support#24213
Micket merged 7 commits intoeasybuilders:developfrom
Thyre:20251012010339_new_pr_Tcl901

Conversation

@Thyre
Copy link
Copy Markdown
Collaborator

@Thyre Thyre commented Oct 11, 2025

(created using eb --new-pr)

See also #24210 (comment).

When CMake searches for Tk & Tcl, it first tries to find the generic libraries before trying version specific ones. Since we did not provide them before this PR, this could lead to system libraries being picked up instead, yielding weird compile failures (or even failures during the CMake step).

In addition, not all software is aware of the name changes in Tcl/Tk 9.0 yet. Since these libraries names are generic, and were already used before, this may also improve the software support for other software.

With this, we mirror what e.g. Fedora and Arch Linux do for Tcl and Tk, where these libraries are available.
See e.g. here and here

@Thyre Thyre added bug fix 2025b issues & PRs related to 2025b common toolchains and removed change labels Oct 11, 2025
@Thyre Thyre added this to the next release (5.2.0?) milestone Oct 11, 2025
@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Oct 11, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath=/tmp/$USER/ecpr-24213"

@boegelbot
Copy link
Copy Markdown
Collaborator

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24213 EB_ARGS="--installpath=/tmp/$USER/ecpr-24213" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24213 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8300

Test results coming soon (I hope)...

Details

- notification for comment with ID 3393723516 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Oct 11, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor (zen4), 1 x AMD Navi 48 [Radeon RX 9070/9070 XT/9070 GRE] (device id: 0x7550, gfx: gfx1201, driver: 6.17.1-arch1-1), 1 x AMD Raphael (device id: 0x164e, gfx: gfx1036, driver: 6.17.1-arch1-1), Python 3.13.7
See https://gist.github.com/Thyre/afb3f3850b0aa4d61ef6e5322585c90a for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Oct 11, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
Framework - Linux Fedora Linux 43, x86_64, AMD Ryzen AI 7 350 w/ Radeon 860M (zen5), 1 x AMD Krackan [Radeon 840M / 860M Graphics] (device id: 0x1114, gfx: gfx1152, driver: 6.17.1-300.fc43.x86_64), Python 3.14.0
See https://gist.github.com/Thyre/f353f1a88dca60f1e6d6972cdf811538 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/37515571c9d494312d59fdd6dcabdaee for a full test report.

Comment thread easybuild/easyconfigs/t/Tcl/Tcl-9.0.1-GCCcore-14.3.0.eb Outdated
Comment thread easybuild/easyconfigs/t/Tcl/Tcl-9.0.1-GCCcore-14.3.0.eb Outdated
Comment thread easybuild/easyconfigs/t/Tk/Tk-9.0.1-GCCcore-14.3.0.eb Outdated
Comment thread easybuild/easyconfigs/t/Tk/Tk-9.0.1-GCCcore-14.3.0.eb Outdated
Signed-off-by: Jan André Reuter <[email protected]>
Micket
Micket previously approved these changes Oct 12, 2025
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 12, 2025

Lets let build it for real on jsc-zen3?

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Oct 12, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24213 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24213 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8301

Test results coming soon (I hope)...

Details

- notification for comment with ID 3393754799 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 12, 2025

Test report by @Micket
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
vera-icelake-build - Linux Rocky Linux 9.6, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.9.21
See https://gist.github.com/Micket/39f8d5609cc7c6bfad15c0bb100bda56 for a full test report.

Signed-off-by: Jan André Reuter <[email protected]>
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/0fa3233940e332206ed1f8f82b98e21a for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Oct 12, 2025

@boegelbot please test @ jsc-zen3

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Oct 12, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jrc0900.jureca - Linux Rocky Linux 9.6, AArch64, ARM UNKNOWN (neoverse_v2), 1 x NVIDIA NVIDIA GH200 480GB, 580.65.06, Python 3.9.21
See https://gist.github.com/Thyre/58ac68971d09010696cab9bd6a6b0a57 for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Oct 12, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor (zen4), 1 x AMD Navi 48 [Radeon RX 9070/9070 XT/9070 GRE] (device id: 0x7550, gfx: gfx1201, driver: Linuxversion6.17.1-arch1-1(linux@archlinux)(gcc(GCC)15.2.120250813,GNUld(GNUBinutils)2.45.0)#1SMPPREEMPT_DYNAMICMon,06Oct202518:48:29+0000), 1 x AMD Raphael (device id: 0x164e, gfx: gfx1036, driver: Linuxversion6.17.1-arch1-1(linux@archlinux)(gcc(GCC)15.2.120250813,GNUld(GNUBinutils)2.45.0)#1SMPPREEMPT_DYNAMICMon,06Oct202518:48:29+0000), Python 3.13.7
See https://gist.github.com/Thyre/0a15612f1b51556dd6546aa4e3783b8b for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 12, 2025

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-icelake-build - Linux Rocky Linux 9.6, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.9.21
See https://gist.github.com/Micket/70b73438d85fb339a98764e612c1b9de for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24213 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24213 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8303

Test results coming soon (I hope)...

Details

- notification for comment with ID 3393762712 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/1233c59477a1d4c07d53b21f1298b2ca for a full test report.

@Micket Micket merged commit 97330d9 into easybuilders:develop Oct 12, 2025
8 checks passed
Thyre added a commit to Thyre/easybuild-easyconfigs that referenced this pull request Oct 13, 2025
akesandgren added a commit that referenced this pull request Oct 13, 2025
Fix shared library links in Tcl/Tk 9.0.1 (follow-up to #24213)
@boegel boegel removed the change label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2025b issues & PRs related to 2025b common toolchains bug fix ready-to-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants