Skip to content

add missing dependencies needed by aiida-core for the RESTapi and for atomic_tools + change toolchain to from gfbf/2023a to foss/2023a#24238

Merged
boegel merged 3 commits intoeasybuilders:developfrom
Crivella:feature-aiida_rest
Oct 15, 2025
Merged

add missing dependencies needed by aiida-core for the RESTapi and for atomic_tools + change toolchain to from gfbf/2023a to foss/2023a#24238
boegel merged 3 commits intoeasybuilders:developfrom
Crivella:feature-aiida_rest

Conversation

@Crivella
Copy link
Copy Markdown
Contributor

@Crivella Crivella commented Oct 14, 2025

  • Added dependencies required by the CLI verdi restapi subcommand
  • Added extra dependencies from [atomic_tools]. Replaces: {tools}[foss/2023a] aiida-atomictools #20458
  • Removed verdi status sanity check as it could fail if some non mandatory services are not found with an existing profile under $HOME/.aiida

Notes

I am not adding a verdi restapi check as the --help would not fail even without deps and properly testing it requires having a profile setup

@Crivella
Copy link
Copy Markdown
Contributor Author

@boegelbot please test @ jsc-zen3

@Crivella
Copy link
Copy Markdown
Contributor Author

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/451bf10e52cf8725dc570a60bd2729fa for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24238 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24238 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8363

Test results coming soon (I hope)...

Details

- notification for comment with ID 3401695666 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Crivella Crivella changed the title Added deps needed by aiida for the RESTapi Added deps needed by aiida for the RESTapi and for atomic_tools Oct 14, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/51dda3568987f4a1b7948311beb657b8 for a full test report.

@Crivella
Copy link
Copy Markdown
Contributor Author

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/8637f08ad5b7725881c8ae5666ddc14e for a full test report.

@Crivella Crivella removed the change label Oct 14, 2025
@Crivella
Copy link
Copy Markdown
Contributor Author

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/436910abd191d7f82d4e768ea1965713 for a full test report.

@Crivella
Copy link
Copy Markdown
Contributor Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24238 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24238 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8364

Test results coming soon (I hope)...

Details

- notification for comment with ID 3401870304 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/6498a56189e076196be797550414e5c9 for a full test report.

@boegel boegel changed the title Added deps needed by aiida for the RESTapi and for atomic_tools add missing dependencies needed by aiida-core for the RESTapi and for atomic_tools + change toolchain to from gfbf/2023a to foss/2023a Oct 14, 2025
@@ -82,7 +111,6 @@ exts_list = [

sanity_check_commands = [
'verdi --help',
'verdi status',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crivella Why was this removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What it does to check the status can depend on what you have in $HOME/.aiida
If you have already a profile it can fail for various reason, eg RabbitMQ or Postgres setup but not running.

We would need a more dedicated integration testing to use.
When i first made the EC i did not have trouble with it as i was starting with an empty profile.

One alternative could be to point AIIDA_HOME to a tmpdir but not sure i would rely on it still

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, verdi --help should be good enough anyway, thanks for clarifying

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 14, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3512.doduo.os - Linux RHEL 9.6, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/boegel/e19e24da936ce6d1dc81f17b83603ac8 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 15, 2025

Going in, thanks @Crivella!

@boegel boegel merged commit 65208af into easybuilders:develop Oct 15, 2025
8 checks passed
@Crivella Crivella deleted the feature-aiida_rest branch October 15, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants