Skip to content

Fix source distribution CI check#24289

Merged
Micket merged 2 commits intoeasybuilders:developfrom
Flamefire:test-fix
Oct 17, 2025
Merged

Fix source distribution CI check#24289
Micket merged 2 commits intoeasybuilders:developfrom
Flamefire:test-fix

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

Due to a recent change in setuptools and/or distutils python setup.py sdist normalizes filenames by replacing dashes by underscores.
We need to detect this and refer to the file with or without underscore.

Also put output into groups instead of silencing it

Due to a recent change in setuptools and/or distutils
`python setup.py sdist` normalizes filenames by replacing dashes by
underscores.
We need to detect this and refer to the file with or without underscore.

Also put output into groups instead of silencing it
Micket
Micket previously approved these changes Oct 17, 2025
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the bug fix label Oct 17, 2025
@Micket Micket added this to the next release (5.2.0?) milestone Oct 17, 2025
@Flamefire Flamefire marked this pull request as draft October 17, 2025 11:38
@Flamefire Flamefire marked this pull request as ready for review October 17, 2025 11:44
Comment thread .github/workflows/unit_tests.yml
@Flamefire
Copy link
Copy Markdown
Contributor Author

There was a similar issue with the tar command used in another test

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit f17a44c into easybuilders:develop Oct 17, 2025
8 checks passed
@Flamefire Flamefire deleted the test-fix branch October 17, 2025 12:13
@boegel boegel added the tests label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants