Skip to content

{bio} [goolf-1.4.10] PRINSEQ-0.20.4-goolf-1.4.10-Perl-5.16.3.eb (REVIEW) #2437

Merged
boegel merged 2 commits intoeasybuilders:developfrom
pescobar:PRINSEQ
Feb 5, 2016
Merged

{bio} [goolf-1.4.10] PRINSEQ-0.20.4-goolf-1.4.10-Perl-5.16.3.eb (REVIEW) #2437
boegel merged 2 commits intoeasybuilders:developfrom
pescobar:PRINSEQ

Conversation

@pescobar
Copy link
Copy Markdown
Member

@pescobar pescobar commented Feb 2, 2016

This application is the typical bioinformatics perl script which depends on many extra perl libraries. How I was managing this kind of installation before was adding the perl libraries dependencies to my main Perl easyconfig. This was leading to a really huge list of libraries / extensions in my main perl easyconfig. Inspired by the bundle easyblock I tried this weird easyconfig which uses the tarball easyblock with extra perl extensions to try to keep the perl script and it's dependencies more self-contained.

I am curious to listen @boegel complains :P Do you have any suggestion about a better approach?

I think this can be useful for people deploying bioinfo stuff where this kind of perl applications are quite common CC: @fgeorgatos @pforai @cfenoy @rjeschmi @georg-rath

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5932/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@rjeschmi
Copy link
Copy Markdown
Contributor

rjeschmi commented Feb 3, 2016

It looks OK to me. I'll try to test it.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 4, 2016

@pescobar: this approach makes perfect sense to me

@wpoely86: style review?

@boegel boegel added this to the v2.7.0 milestone Feb 4, 2016
version = '0.20.4'

homepage = 'http://prinseq.sourceforge.net'
description = """ A bioinformatics tool to PRe-process and show INformation of SEQuence data. """
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop whitespace before and after

@rjeschmi
Copy link
Copy Markdown
Contributor

rjeschmi commented Feb 4, 2016

I'd prefer if it got merged with a newer compiler option too (1.7.20 or a foss option).

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 4, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/40022841b8a807d3c5fa for a full test report.

}

postinstallcmds = ["sed -i -e 's|/usr/bin/perl|/usr/bin/env\ perl|' %(installdir)s/*.pl", # fix shebang line
"chmod +x %(installdir)s/*.pl"] # add execution permission
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format like:

postinstallcmds = [
    "sed ...",  # fix shebang line
    "chmod ...",  # add execution permisson
]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually needs to be moved to the generic Perl extension block. The Python one implements patching wrong shebangs.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue on that in the easyblocks repo?

Or submit a PR for it. ;-)

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5945/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 5, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/044ab79951ad2418ac3b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 5, 2016

Good to go (moving the sed thing to the Perl easyblock will be done later), thanks @pescobar!

boegel added a commit that referenced this pull request Feb 5, 2016
{bio} [goolf-1.4.10] PRINSEQ-0.20.4-goolf-1.4.10-Perl-5.16.3.eb (REVIEW)
@boegel boegel merged commit c7bc7c2 into easybuilders:develop Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants