{lib}[foss/2025a] neko v0.9.1#24438
Conversation
Thyre
left a comment
There was a problem hiding this comment.
Thanks for your PR 😄
I've added a few comments on how the PR could be improved. I'm not familiar with neko, but maybe they help a bit regardless.
| sources = ['v%(version)s.tar.gz'] | ||
|
|
||
| dependencies = [ | ||
| ('json-fortran', '8.3.0'), |
There was a problem hiding this comment.
I'd first try it with json-fortran-9.0.5-GCC-14.2.0.eb to see if that will work here; otherwise it's introducing a fork where we end up with incompatible modules inside the toolchain which is always a pain in the butt.
There was a problem hiding this comment.
I am unsure if I should have ('json-fortran', '9.0.5-GCC-14.2.0', '', True) or just ('json-fortran', '9.0.5')
|
Thank you for the very helpful comments. I have tried to address them. With that said, I totally get your points but I haven't been able to test this updated version of the eb file yet. |
|
@tuananhdao Just to mention, there is a licencing problem with ParMetis (it does not have an open source licence that allows us to redistribute) and we cannot include that in EESSI. That doesn't mean you can't include it in your final recipe here, but be aware that we will have to filter it out on the EESSI side. |
|
Also FYI, I noticed Neko has support for ADIOS2, there is ongoing work to include that in EB (see #23215 and other related PRs) |
Micket
left a comment
There was a problem hiding this comment.
lgtm
We could hold of for ADIOS2 is we get those tests passing there, if ADIOS2 is an important dependency for neko (I have no idea)
ADIOS2 is optional. But I agree we should include that when ADIOS2 is included in eb. The only required dependency is json-fortran. |
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3507844461 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
@boegelbot please test @ jsc-zen3 |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3649596457 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @tuananhdao! |
|
I'm also looking into adding this to EESSI: Neko 1.0.0 has been released recently, we should probably also look into that... |
(created using
eb --new-pr)Requires