Skip to content

{lib}[foss/2025a] neko v0.9.1#24438

Merged
boegel merged 14 commits intoeasybuilders:developfrom
tuananhdao:20251103000421_new_pr_neko091
Dec 13, 2025
Merged

{lib}[foss/2025a] neko v0.9.1#24438
boegel merged 14 commits intoeasybuilders:developfrom
tuananhdao:20251103000421_new_pr_neko091

Conversation

@tuananhdao
Copy link
Copy Markdown
Contributor

@tuananhdao tuananhdao commented Nov 2, 2025

(created using eb --new-pr)

Requires

@github-actions github-actions Bot added the new label Nov 2, 2025
@Thyre Thyre added the 2025a issues & PRs related to 2025a common toolchains label Nov 3, 2025
Copy link
Copy Markdown
Collaborator

@Thyre Thyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 😄
I've added a few comments on how the PR could be improved. I'm not familiar with neko, but maybe they help a bit regardless.

Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a-cpu.eb Outdated
Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a-cpu.eb Outdated
Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a-cpu.eb Outdated
Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a-cpu.eb Outdated
Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a-cpu.eb Outdated
Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a-cpu.eb Outdated
Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a.eb
Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a.eb
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • all the stuff Thyre said

Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a.eb
sources = ['v%(version)s.tar.gz']

dependencies = [
('json-fortran', '8.3.0'),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd first try it with json-fortran-9.0.5-GCC-14.2.0.eb to see if that will work here; otherwise it's introducing a fork where we end up with incompatible modules inside the toolchain which is always a pain in the butt.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure if I should have ('json-fortran', '9.0.5-GCC-14.2.0', '', True) or just ('json-fortran', '9.0.5')

@tuananhdao
Copy link
Copy Markdown
Contributor Author

Hi @Micket and @Thyre,

Thank you for the very helpful comments. I have tried to address them.
I am from the neko dev team trying to get neko into EESSI.
I wanted to try only the bare minimum version of neko in first since EESSI 2025a doesn't have parmetis, json-fortran yet. The 2023b has them but I think going for 2025a is better. I will submit the missing packages to their repo as well.

With that said, I totally get your points but I haven't been able to test this updated version of the eb file yet.

@tuananhdao tuananhdao requested review from Micket and Thyre November 5, 2025 20:32
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Nov 6, 2025

@tuananhdao Just to mention, there is a licencing problem with ParMetis (it does not have an open source licence that allows us to redistribute) and we cannot include that in EESSI. That doesn't mean you can't include it in your final recipe here, but be aware that we will have to filter it out on the EESSI side.

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Nov 6, 2025

Also FYI, I noticed Neko has support for ADIOS2, there is ongoing work to include that in EB (see #23215 and other related PRs)

@Micket Micket changed the title {lib}[foss/2025a] neko v0.9.1 w/ cpu {lib}[foss/2025a] neko v0.9.1 Nov 7, 2025
Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a.eb Outdated
Micket
Micket previously approved these changes Nov 7, 2025
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

We could hold of for ADIOS2 is we get those tests passing there, if ADIOS2 is an important dependency for neko (I have no idea)

Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a.eb
@tuananhdao
Copy link
Copy Markdown
Contributor Author

lgtm

We could hold of for ADIOS2 is we get those tests passing there, if ADIOS2 is an important dependency for neko (I have no idea)

ADIOS2 is optional. But I agree we should include that when ADIOS2 is included in eb.

The only required dependency is json-fortran.

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Nov 9, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24438 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24438 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8703

Test results coming soon (I hope)...

Details

- notification for comment with ID 3507844461 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (total: 31 secs) (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/28192cb7260a896caf591439d5a31a84 for a full test report.

Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a.eb Outdated
Comment thread easybuild/easyconfigs/n/neko/neko-0.9.1-foss-2025a.eb Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 13, 2025

@boegelbot please test @ jsc-zen3

@boegel boegel added the EuroHPC label Dec 13, 2025
@boegel boegel added this to the next release (5.2.0?) milestone Dec 13, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24438 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24438 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9118

Test results coming soon (I hope)...

Details

- notification for comment with ID 3649596457 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (total: 3 mins 18 secs) (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/cdd610e370cdcb0f57464ff71d1c5e47 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 13, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (total: 3 mins 36 secs) (1 easyconfigs in total)
node4245.shinx.os - Linux RHEL 9.6, x86_64, AMD EPYC 9654 96-Core Processor (zen4), Python 3.9.21
See https://gist.github.com/boegel/09d8aeb97f3e0da24a892f49e2ac3df2 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 13, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (total: 3 mins 20 secs) (1 easyconfigs in total)
node3535.doduo.os - Linux RHEL 9.6, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/boegel/e8aac9f61dbbf90fa9f9411857019a62 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 13, 2025

Going in, thanks @tuananhdao!

@boegel boegel merged commit 32d6d1b into easybuilders:develop Dec 13, 2025
8 checks passed
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 13, 2025

I'm also looking into adding this to EESSI:

Neko 1.0.0 has been released recently, we should probably also look into that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2025a issues & PRs related to 2025a common toolchains EuroHPC new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants