enhance tagbot workflow to add toolchain labels#24439
enhance tagbot workflow to add toolchain labels#24439Crivella merged 5 commits intoeasybuilders:developfrom
Conversation
Similar to our existing workflow for labeling, add toolchain labels to created PRs by checking for the file names and match this against known toolchains. This requires manual updating the workflow once we establish new toolchains, similar to our test steps. This also doesn't cover NVHPC & LLVM yet, since the checked strings include explicit toolchain names to reduce incorrect labels. Signed-off-by: Jan André Reuter <[email protected]>
Signed-off-by: Jan André Reuter <[email protected]>
Signed-off-by: Jan André Reuter <[email protected]>
|
Might require a bit more testing, but looked good for the test PR I did... |
Micket
left a comment
There was a problem hiding this comment.
lgtm. do you have any reason to believe this isn't working correctly?
Nothing in particular, no. All the labels are present (and would get created if they were not, as far as I understand) and the tests looked good so far. I only tested a few selections, but those should theoretically be sufficient enough. I couldn't think of some EasyConfig we already have that breaks the labeling, but this is a non-critical component. If something is wrong, we can still revert or fix this. |
Crivella
left a comment
There was a problem hiding this comment.
Would not say required but suggestions to improve readability
| for gcc_version in gcc_tc_gen_map.keys(): | ||
| if f"-GCCcore-{gcc_version}" in file_path or f"-GCC-{gcc_version}" in file_path: | ||
| toolchain_present[gcc_tc_gen_map[gcc_version]] = True | ||
| continue |
There was a problem hiding this comment.
| for gcc_version in gcc_tc_gen_map.keys(): | |
| if f"-GCCcore-{gcc_version}" in file_path or f"-GCC-{gcc_version}" in file_path: | |
| toolchain_present[gcc_tc_gen_map[gcc_version]] = True | |
| continue | |
| for gcc_version, tc_version in gcc_tc_gen_map.items(): | |
| if f"-GCCcore-{gcc_version}" in file_path or f"-GCC-{gcc_version}" in file_path: | |
| toolchain_present[tc_version] = True | |
| continue |
|
Will add them tomorrow, but I they‘re certainly a good idea. |
Co-authored-by: crivella <[email protected]> Signed-off-by: Jan André Reuter <[email protected]>
Signed-off-by: Jan André Reuter <[email protected]>
|
Labeling still seems to work fine, as tested by removing all the labels and re-running the CI in Thyre#1 |
|
Going in, thanks @Thyre! |
Expand our label job to automatically add toolchain labels to PRs.
This covers both added and changed EasyConfigs.
The labeling only covers toolchains also checked in our test suite, and only GCC + Intel for now.
Generally, this should allow us to better keep track of PRs and their touched toolchains, and filter more easily by using respective labels. Relying on PR titles might not always work, since not everyone is using
eb --new-pr.For a test, see: Thyre#1