Skip to content

Fix SOURCES#248

Merged
boegel merged 9 commits intoeasybuilders:developfrom
fgeorgatos:fix_SOURCES
May 6, 2013
Merged

Fix SOURCES#248
boegel merged 9 commits intoeasybuilders:developfrom
fgeorgatos:fix_SOURCES

Conversation

@fgeorgatos
Copy link
Copy Markdown
Contributor

Boring yet done; the remaining cases to fix now are roughly:

  • filenames containing underscore (needs framework extension)
  • .tar (needs framework extension)
  • .zip (needs framework extension)
$ grep ^sources */*/*eb|grep %s|cut -d: -f2|sort|uniq -c|sort|head     
     10 sources = ['%s%s-src.tar.gz' % (name.lower(), version)]
     10 sources = ['%s_%s.tar.gz' % (name.lower(), '_'.join(version.split('.')))]
     10 sources = ['%s-%s.tar' % (name, version)]
     10 sources = ['%s-%s.zip' % (name.lower(), version)]
     11 sources = ['CP2K-%s.tar.gz' % version]
     16 sources = ['%sV%s.TAR.gz' % (name, version)]
      1 sources = ['CFX%s%s_LINX64-without_helpfiles.tar' % (name, ''.join(version.split('.')))]
      1 sources = ['cplex_studio%s.linux-x86-64.bin' % ''.join(version.split('.'))]
      1 sources = ['inspector_xe_%s.tar.gz' % version]
      1 sources = ['l_cproc_p_%s_intel64.tgz' % version]

Didn't look into the source_urls yet; that may require some look into pkgsrc ideas.

fgeorgatos added 6 commits May 1, 2013 12:46
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
@fgeorgatos
Copy link
Copy Markdown
Contributor Author

btw. the scope of the PR is intentional, because the unit tests of building individual packages would catch potential issues early on (this is not the case with source_urls). Going offline for today, enjoy.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 3, 2013

Please open an issue, or better yet, a PR, to add support for the missing constants in the framework. See TEMPLATE_CONSTANTS in easybuild/framework/easyconfig/templates.py.

fix VTK sources code style & sync with develop
@boegel
Copy link
Copy Markdown
Member

boegel commented May 6, 2013

Reviewed, no remarks except for the ones in fgeorgatos#14, unit tests are fine, so merging it in.

boegel added a commit that referenced this pull request May 6, 2013
@boegel boegel merged commit d056419 into easybuilders:develop May 6, 2013
@fgeorgatos fgeorgatos deleted the fix_SOURCES branch May 21, 2013 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants