Merged
Conversation
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
Contributor
Author
|
btw. the scope of the PR is intentional, because the unit tests of building individual packages would catch potential issues early on (this is not the case with |
Member
|
Please open an issue, or better yet, a PR, to add support for the missing constants in the framework. See |
fix VTK sources code style & sync with develop
Member
|
Reviewed, no remarks except for the ones in fgeorgatos#14, unit tests are fine, so merging it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boring yet done; the remaining cases to fix now are roughly:
Didn't look into the source_urls yet; that may require some look into pkgsrc ideas.