Skip to content

make NASM a build-only dependency for ISA-L#24842

Merged
smoors merged 1 commit intoeasybuilders:developfrom
Micket:20251212113200_new_pr_ISA-L2300
Dec 12, 2025
Merged

make NASM a build-only dependency for ISA-L#24842
smoors merged 1 commit intoeasybuilders:developfrom
Micket:20251212113200_new_pr_ISA-L2300

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Dec 12, 2025

(created using eb --new-pr)

@github-actions github-actions Bot added 2021a 2021b issues & PRs related to 2021b 2022a 2022b 2023a 2023b 2024a issues & PRs related to 2024a common toolchains change labels Dec 12, 2025
smoors
smoors approved these changes Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the next release (5.2.0?) milestone Dec 12, 2025
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 12, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 12, 2025

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24842 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24842 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9112

Test results coming soon (I hope)...

Details

- notification for comment with ID 3646393951 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 12, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (total: 12 mins 2 secs) (7 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/07214d269159a2c6ed38c883cfecaf3f for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 12, 2025

Going in, thanks @Micket!

@smoors smoors merged commit 26ce5fb into easybuilders:develop Dec 12, 2025
8 checks passed
@Micket Micket deleted the 20251212113200_new_pr_ISA-L2300 branch December 12, 2025 14:05
@boegel boegel changed the title NASM should just be a builddep in ISA-L make NASM a build-only dependency for ISA-L Dec 19, 2025
@boegel boegel added bug fix and removed change labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

2021a 2021b issues & PRs related to 2021b 2022a 2022b 2023a 2023b 2024a issues & PRs related to 2024a common toolchains bug fix

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Micket @smoors @boegelbot @boegel