Skip to content

change NASM to build-only dependency for Tensorflow#24844

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Micket:20251212113643_new_pr_TensorFlow2110
Dec 14, 2025
Merged

change NASM to build-only dependency for Tensorflow#24844
boegel merged 1 commit intoeasybuilders:developfrom
Micket:20251212113643_new_pr_TensorFlow2110

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Dec 12, 2025

(created using eb --new-pr)

@github-actions github-actions Bot added 2021a 2021b issues & PRs related to 2021b 2022a 2022b 2023a 2024a issues & PRs related to 2024a common toolchains change labels Dec 12, 2025
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title NASM should just be a builddep in Tensorflow change NASM to build-only dependency for Tensorflow Dec 13, 2025
@boegel boegel added this to the next release (5.2.0?) milestone Dec 13, 2025
@boegel boegel added the bug fix label Dec 13, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 13, 2025

@boegelbot please test @ jsc-zen3-a100
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER/pr24844 TensorFlow-2.18.1-foss-2024a-CUDA-12.6.0.eb TensorFlow-2.15.1-foss-2023a-CUDA-12.1.1.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24844 EB_ARGS="--installpath /tmp/$USER/pr24844 TensorFlow-2.18.1-foss-2024a-CUDA-12.6.0.eb TensorFlow-2.15.1-foss-2023a-CUDA-12.1.1.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24844 --ntasks="16" --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9122

Test results coming soon (I hope)...

Details

- notification for comment with ID 3649668988 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 13, 2025

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER/pr24844 TensorFlow-2.13.0-foss-2023a.eb TensorFlow-2.15.1-foss-2023a.eb TensorFlow-2.18.1-foss-2024a.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24844 EB_ARGS="--installpath /tmp/$USER/pr24844 TensorFlow-2.13.0-foss-2023a.eb TensorFlow-2.15.1-foss-2023a.eb TensorFlow-2.18.1-foss-2024a.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24844 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9125

Test results coming soon (I hope)...

Details

- notification for comment with ID 3649724556 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 13, 2025

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (total: 3 hours 36 mins 14 secs) (2 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 580.95.05, Python 3.9.21
See https://gist.github.com/boegelbot/ab2b62e18ff09a4d4a4d575e8242b0c0 for a full test report.

edit (by @boegel): test build of TensorFlow-2.18.1-foss-2024a-CUDA-12.6.0.eb failed with:

ERROR: /tmp/boegelbot/TensorFlow/2.18.1/foss-2024a-CUDA-12.6.0/TensorFlow/bazel-root/22f314d76a6bde6e83c76c9731f563f8/external/com_google_protobuf/BUILD.bazel:75:11: Compiling src/google/protobuf/io/gzip_stream.cc [for tool] failed: undeclared inclusion(s) in rule '@com_google_protobuf//:protobuf':
this rule is missing dependency declarations for the following files included by 'src/google/protobuf/io/gzip_stream.cc':
  '/project/60006/boegelbot/rocky9/zen3/software/zlib/1.3.1-GCCcore-13.3.0/include/zconf.h'

It's pretty clear that has nothing to do with the changes being made here...

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (total: 6 hours 35 mins 46 secs) (3 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/218b6960b98ba5d86008a2f948d9d96c for a full test report.

@boegel boegel merged commit 558bb24 into easybuilders:develop Dec 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2021a 2021b issues & PRs related to 2021b 2022a 2022b 2023a 2024a issues & PRs related to 2024a common toolchains bug fix change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants