Skip to content

Make SimpleITK pick the right Lua binary#24908

Merged
smoors merged 1 commit intoeasybuilders:developfrom
PetrKralCZ:20251217121158_new_pr_SimpleITK231
Dec 17, 2025
Merged

Make SimpleITK pick the right Lua binary#24908
smoors merged 1 commit intoeasybuilders:developfrom
PetrKralCZ:20251217121158_new_pr_SimpleITK231

Conversation

@PetrKralCZ
Copy link
Copy Markdown
Collaborator

@PetrKralCZ PetrKralCZ commented Dec 17, 2025

(created using eb --new-pr)

@github-actions github-actions Bot added 2023a 2023b 2024a issues & PRs related to 2024a common toolchains change labels Dec 17, 2025
@PetrKralCZ PetrKralCZ mentioned this pull request Dec 17, 2025
Open
@PetrKralCZ
Copy link
Copy Markdown
Collaborator Author

PetrKralCZ commented Dec 17, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 17, 2025

@PetrKralCZ: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24908 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24908 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9223

Test results coming soon (I hope)...

Details

- notification for comment with ID 3664872607 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 17, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (total: 2 hours 0 mins 31 secs) (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/006277353b524e3fe8ff4caabb4a419f for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 17, 2025

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (total: 34 mins 29 secs) (1 easyconfigs in total)
node703.hydra.os - Linux Rocky Linux 9.6, x86_64, AMD EPYC 9535 64-Core Processor (zen5), Python 3.9.21
See https://gist.github.com/smoors/9e6b49578ffcaf36d58bb503f1ab0b7f for a full test report.

@smoors smoors added this to the release after 5.2.0 milestone Dec 17, 2025
smoors
smoors approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 17, 2025

Going in, thanks @PetrKralCZ!

@smoors smoors merged commit 638041d into easybuilders:develop Dec 17, 2025
8 checks passed
@boegel boegel added bug fix EESSI Related to EESSI project and removed change labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

2023a 2023b 2024a issues & PRs related to 2024a common toolchains bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@PetrKralCZ @boegelbot @smoors @boegel