Skip to content

Remove unused configopt due to repetition in Graphviz easyconfigs#25189

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
Crivella:fix-graphviz_java
Feb 4, 2026
Merged

Remove unused configopt due to repetition in Graphviz easyconfigs#25189
branfosj merged 1 commit intoeasybuilders:developfrom
Crivella:fix-graphviz_java

Conversation

@Crivella
Copy link
Copy Markdown
Contributor

@Crivella Crivella commented Jan 30, 2026

Only the last option is used by ./configure.
Since the last one is the correct one, no failure is seen in the builds but this can mess up hooks that do stuff on the configopts without keeping order.

See for example

@Crivella Crivella added bug fix EESSI Related to EESSI project labels Jan 30, 2026
@github-actions github-actions Bot added 2022b 2023a 2023b 2024a issues & PRs related to 2024a common toolchains 2025a issues & PRs related to 2025a common toolchains 2025b issues & PRs related to 2025b common toolchains change labels Jan 30, 2026
@github-actions github-actions Bot removed the 2022b label Jan 30, 2026
@Crivella
Copy link
Copy Markdown
Contributor Author

Crivella commented Jan 30, 2026

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 30, 2026

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25189 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25189 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9530

Test results coming soon (I hope)...

Details

- notification for comment with ID 3822958353 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Crivella
Copy link
Copy Markdown
Contributor Author

Crivella commented Jan 30, 2026

Test report by @Crivella
SUCCESS
Build succeeded for 7 out of 7 (total: 20 mins 36 secs) (5 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.14
See https://gist.github.com/Crivella/893c28bb565f1a41eb0267aa46b4b7ac for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 30, 2026

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (total: 1 hour 0 mins 22 secs) (5 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.23
See https://gist.github.com/boegelbot/9ea6bda78885fd6b99d7367f124d6227 for a full test report.

@Crivella Crivella assigned casparvl and unassigned casparvl Jan 30, 2026
@Crivella Crivella requested a review from casparvl January 30, 2026 11:24
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 4, 2026

Test report by @branfosj
SUCCESS
Build succeeded for 10 out of 10 (total: 17 hours 28 mins 24 secs) (5 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/4201df1dbd326c42c2e95b827196245c for a full test report.

@branfosj branfosj added this to the next release (5.2.1?) milestone Feb 4, 2026
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 4, 2026

Going in, thanks @Crivella!

@branfosj branfosj merged commit 1ac7375 into easybuilders:develop Feb 4, 2026
8 checks passed
@Crivella Crivella deleted the fix-graphviz_java branch February 4, 2026 08:58
@Crivella Crivella mentioned this pull request Feb 4, 2026
Merged
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 4, 2026

Test report by @branfosj
SUCCESS
Build succeeded for 32 out of 32 (total: 26 hours 27 mins 22 secs) (5 easyconfigs in total)
bear-pg0210u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8480CL (sapphirerapids), Python 3.6.8
See https://gist.github.com/branfosj/0d97913298b57b9567f1d0addd1a5247 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

@casparvl casparvl Awaiting requested review from casparvl

Assignees

No one assigned

Labels

2023a 2023b 2024a issues & PRs related to 2024a common toolchains 2025a issues & PRs related to 2025a common toolchains 2025b issues & PRs related to 2025b common toolchains bug fix EESSI Related to EESSI project ready-to-review

Projects

None yet

Milestone

5.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Crivella @boegelbot @branfosj @casparvl