Skip to content

Make sure that ReFrame script has executable permissions#25338

Merged
boegel merged 1 commit intoeasybuilders:developfrom
stevenvdb:20260219143257_new_pr_ReFrame474
Apr 9, 2026
Merged

Make sure that ReFrame script has executable permissions#25338
boegel merged 1 commit intoeasybuilders:developfrom
stevenvdb:20260219143257_new_pr_ReFrame474

Conversation

@stevenvdb
Copy link
Copy Markdown
Contributor

@stevenvdb stevenvdb commented Feb 19, 2026 •
edited
Loading

We noticed that recent ReFrame installations were failing with:

== FAILED: Installation ended unsuccessfully: Sanity check failed: sanity check command reframe --version failed with exit code 126 (output: /usr/bin/bash: line 1: /scratch/leuven/sys/x0139045/tmpbuild/software/ReFrame/4.8.2-GCCcore-14.2.0/bin/reframe: Permission denied

The problem only occurs for when the installation directory is located on Lustre (lfs 2.15.5.4_cray_11_g915a789 specifically), but for instance not when the installation directory is on NFS. The problem is that the postinstallcmd

sed --in-place 's@/\(python[0-9.]*\)$@/\1 -S@g' %(installdir)s/bin/reframe

does not really edit the file in-place, it creates a temporary copy and then replaces the original file. Apparently, on some file systems this removes existing permissions. The proposed changes ensure that the reframe script has executable permissions at the moment the sanity check is executed.

(created using eb --new-pr)

@github-actions github-actions Bot added 2023b 2024a issues & PRs related to 2024a common toolchains 2025a issues & PRs related to 2025a common toolchains 2025b issues & PRs related to 2025b common toolchains change labels Feb 19, 2026
Micket
Micket approved these changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmm i suppose it's a side effect of some sort of copy-on-write filesystem and sed?

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 21, 2026

@boegelbot please test @ jsc-zen3

@Micket Micket added this to the next release (5.2.2?) milestone Mar 21, 2026
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2026

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25338 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25338 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10070

Test results coming soon (I hope)...

Details

- notification for comment with ID 4101560750 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2026

Test report by @boegelbot
FAILED
Failed during parsing of the easyconfigs, so no ecs were built (8 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/c434d83dc7afc2d48f395664fe88e443 for a full test report.

boegel
boegel approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 8, 2026

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/25338 --ignore-osdeps"

@easybuilders easybuilders deleted a comment from boegelbot Apr 8, 2026
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 8, 2026

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25338 EB_ARGS="--installpath /tmp/$USER/25338 --ignore-osdeps" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25338 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10200

Test results coming soon (I hope)...

Details

- notification for comment with ID 4210107123 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 8, 2026

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (total: 11 mins 44 secs) (8 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/636ae834c48e73e777c4e23fa1410211 for a full test report.

@boegel boegel added bug fix and removed change labels Apr 8, 2026
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 9, 2026

Going in, thanks @stevenvdb!

@boegel boegel merged commit 418bda9 into easybuilders:develop Apr 9, 2026
8 checks passed
@boegel boegel changed the title Make sure that reframe script has executable permissions Make sure that ReFrame script has executable permissions Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

2023b 2024a issues & PRs related to 2024a common toolchains 2025a issues & PRs related to 2025a common toolchains 2025b issues & PRs related to 2025b common toolchains bug fix

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@stevenvdb @Micket @boegelbot @boegel