{bio}[foss/2015b] NextClip (REVIEW)#2544
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
The script directory contains Perl scripts - should Perl then be added as a dependency? |
|
Jenkins: ok to test |
|
@nathanhaigh: I'd say that depends on how important those scripts are... Are they considered to be a main part of this software, or just helper scripts that happen to be included? |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6504/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
@nathanhaigh: let me know what you'll do w.r.t. the Perl dep, otherwise good to go |
|
I'd say they were more like helper scripts. On a slightly closer loo, there are also R scripts there as well as Perl scripts. I wouldn't add them. Also the shebang lines of the Perl scripts ought to be changed from |
|
Changing the script to use |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6595/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| +++ b/scripts/nextclip_plot_graphs.sh | ||
| @@ -1,4 +1,4 @@ | ||
| -#!/bin/bash | ||
| +#!/usr/bin/env bash |
There was a problem hiding this comment.
hmm, I think this is very uncommon?
1) Added comment and author. 2) Strip superfluous `-w` from perl shebang line. - the scripts already use the `use warnings;` pragma.
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6608/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| @@ -0,0 +1,51 @@ | |||
| Fix hardcoding of /usr/bin/perl, use perl available through $PATH | |||
| Fix hardcoding of /bin/bash, use bash available through $PATH | |||
There was a problem hiding this comment.
drop this comment if you revert those parts of the patch?
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6643/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Thanks @nathanhaigh! |
{bio}[foss/2015b] NextClip (REVIEW)
No description provided.