Skip to content

make Python, Meson, Ninja, and CMake build dependencies in easyconfigs for btllib 1.7.0 + 1.7.5#25456

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Micket:20260227021945_new_pr_btllib170
Feb 27, 2026
Merged

make Python, Meson, Ninja, and CMake build dependencies in easyconfigs for btllib 1.7.0 + 1.7.5#25456
boegel merged 1 commit intoeasybuilders:developfrom
Micket:20260227021945_new_pr_btllib170

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Feb 27, 2026

(created using eb --new-pr)

I'm not sure on the Python, whether it's a builddep or dep. Looks like just compiled code here, so, just a builddep makes sense to me.

@github-actions github-actions Bot added 2023a 2024a issues & PRs related to 2024a common toolchains change labels Feb 27, 2026
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Feb 27, 2026

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (total: 1 min 10 secs) (1 easyconfigs in total)
vera-icelake-build - Linux Rocky Linux 9.6, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.9.21
See https://gist.github.com/Micket/906d602199d730cbe9077356aba9f742 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 27, 2026

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (total: 2 mins 9 secs) (2 easyconfigs in total)
node081.viking2.yor.alces.network - Linux Rocky Linux 8.10, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/6916a3d1631dce71260cb96aa36df065 for a full test report.

@Micket Micket added this to the next release (5.2.2?) milestone Feb 27, 2026
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 27, 2026

@Micket according to the docs:

You can optionally run python3 -m pip install $PREFIX/lib/btllib/python afterwards to install the Python package. The Python wrappers are usable even without this step. $PREFIX is the path where btllib is installed.
...
If you compiled btllib from source code and didn't install the Python wrappers, you can use PYTHONPATH environment variable or sys.path.append() in your Python code to include $PREFIX/lib/btllib/python/btllib directory to make btllib available to the interpreter.
Include the library with import btllib

so python should probably be a runtime dependency (and we should make sure the wrapper is installed/usable)?

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 27, 2026

@Micket according to the docs:

You can optionally run python3 -m pip install $PREFIX/lib/btllib/python afterwards to install the Python package. The Python wrappers are usable even without this step. $PREFIX is the path where btllib is installed.
...
If you compiled btllib from source code and didn't install the Python wrappers, you can use PYTHONPATH environment variable or sys.path.append() in your Python code to include $PREFIX/lib/btllib/python/btllib directory to make btllib available to the interpreter.
Include the library with import btllib

so python should probably be a runtime dependency (and we should make sure the wrapper is installed/usable)?

I would say we fix that in another follow-up PR, along with a sanity check for the import, etc.

As it is, Python isn't really a runtime depency at all, so I think we should go ahead and merge this as is, since it's a clear bug fix...

@boegel boegel added bug fix and removed change labels Feb 27, 2026
@boegel boegel changed the title Move some btllib deps to builddeps make Python, Meson, Ninja, and CMake build dependencies in easyconfigs for btllib 1.7.0 + 1.7.5 Feb 27, 2026
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 27, 2026

@boegelbot please test @ jsc-zen3

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25456 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25456 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9896

Test results coming soon (I hope)...

Details

- notification for comment with ID 3975172506 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (total: 4 mins 4 secs) (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.23
See https://gist.github.com/boegelbot/33b7024977e510e069deba0147885d9e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 27, 2026

Going in, thanks @Micket!

@boegel boegel merged commit 1422344 into easybuilders:develop Feb 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2023a 2024a issues & PRs related to 2024a common toolchains bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants