{vis}[intel-2016a] libX11 1.6.3 (REVIEW)#2549
Conversation
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6515/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Test report by @boegel |
|
Looks good, but we need to check some more, I think... This was on systems that have X11 stuff provided by the OS. |
The headers that are included in Tk are not being found here. I think we are missing a -I. I've fixed this before, but haven't merge it.. |
|
I realize that this isn't in this PR, but it is blocking me from testing it .. |
|
I'll follow up here #2261 |
|
so the first deps works but |
|
@rjeschmi add |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6576/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@hajgato: it found which xproto? |
|
@boegel: Ok, I might checked a wrong logfile. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6584/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
I'd like to see @rjeschmi test this again on a minimal system... |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6586/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @rjeschmi |
|
Looks good. Used the foss toolchain and removed Tk from Python, but otherwise good. |
|
So, @hajgato, what do you reckon? |
|
@boegel: I did it, so we should merge it (if passes the checks). Anyway I am working on the "bundle" version as well. If you think it is better to use only the bundle, then we do not have to merge it. |
|
@boegel what happens with if a .py file is compiled to a read only .pyc and .pyo and we change the Python version? Will the .py run, or the .pyo/.pyc? |
|
@boegel |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6604/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6605/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6611/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
|
||
| sanity_check_paths = { | ||
| 'files': ['lib/pkgconfig/xcb-proto.pc'], | ||
| 'dirs': ['lib/python%s/site-packages/xcbgen' % pyshortver] |
There was a problem hiding this comment.
this is an issue...
if the system Python is updated from 2.6 to 2.7, this will not be found anymore?
besides, this is not in $PYTHONPATH anyway, as it is now (same issue when we include our own Python version)...
does that mean the Python bits are basically irrelevant?
There was a problem hiding this comment.
or maybe this is handled via the pkg-config file?
There was a problem hiding this comment.
@boegel: this handled by the pkgconfig:
xcb-proto.pc:
prefix=/apps/brussel/ivybridge/software/xcb-proto/1.11
exec_prefix=${prefix}
datarootdir=${prefix}/share
datadir=${datarootdir}
libdir=${exec_prefix}/lib
xcbincludedir=${datadir}/xcb
pythondir=${prefix}/lib/python2.6/site-packages
Name: XCB Proto
Description: X protocol descriptions for XCB
Version: 1.11
I am more concerned what will happen with the precompiled pyo files if you change Python version. (especially, if they are read-only)
There was a problem hiding this comment.
@boegel:
xcb-proto has only python bits, so they cannot be irrelevant....
There was a problem hiding this comment.
OK, not a problem indeed since it's handled by pkg-config
|
|
||
| builddependencies = [ | ||
| ('xextproto', '7.3.0'), | ||
| ('xcb-proto', '1.11', '-Python-2.7.11'), |
There was a problem hiding this comment.
@hajgato: you missed updating this to use the dummy xcb-proto easyconfig?
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6673/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6674/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6675/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
minor style fixes in X lib easyconfigs
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6680/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @hajgato! |
{vis}[intel-2016b] libX11 1.6.3 (REVIEW)
The following packages were moved to builddeps:
xcb-proto,xextproto,inputproto,kbproto, andibpthread-stubsxcb-protois one pkconfig file, a bunch of Python files and a couple of xml files.xextprotois one pkconfig file, a bunch of header files, and a couple of xml files.inputprotois one pkconfig file, and a couple of header files.kbprotois one pkconfig file, a couple of header files, and a bunch of xml and svg files.libpthread-stubsis one pkconfig file.We have to check this new configuration on a completely X-less machine, and we have to check softwares depend on libX11, they might need (some of) the above modules as builddependencies.
Only
xcp-protodepends on Python, and as it is now only a builddependency,libX11is finally Python free!