use `NETCDF_ENABLE_DAP_REMOTE_TESTS` instead of `ENABLE_DAP_REMOTE_TESTS` and prevent use of `srun` in netCDF 4.9.3 easyconfigs by bedroge · Pull Request #25490 · easybuilders/easybuild-easyconfigs

bedroge · 2026-03-03T13:30:19Z

While debugging some weird netCDF test failures, I found that ENABLE_DAP_REMOTE_TESTS was renamed to NETCDF_ENABLE_DAP_REMOTE_TESTS in 4.9.3. See https://github.com/Unidata/netcdf-c/blob/v4.9.2/CMakeLists.txt#L1098 and
https://github.com/Unidata/netcdf-c/blob/v4.9.3/CMakeLists.txt#L603.

bedroge · 2026-03-03T13:31:30Z

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER/pr25490"

boegelbot · 2026-03-03T13:40:10Z

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25490 EB_ARGS="--installpath /tmp/$USER/pr25490" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25490 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 9929

Test results coming soon (I hope)...

Details

- notification for comment with ID 3991109520 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Thyre · 2026-03-04T08:31:32Z

Posting the comment seems to have failed, but the build succeeded.
See: https://gist.github.com/boegelbot/6fd36f26ab967b360f549083226c8c8c

bedroge · 2026-03-04T10:49:43Z

Test report by @bedroge
FAILED
Build succeeded for 0 out of 2 (total: 52 mins 1 secs) (2 easyconfigs in total)
node1 - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, AMD EPYC 7763 64-Core Processor (zen3), Python 3.12.12
See https://gist.github.com/bedroge/b50ba721c81501cde41a591de7e3ab8e for a full test report.

bedroge · 2026-03-04T12:43:24Z

Okay, that's an interesting test failure:

        Start 150: nc_test4_run_par_warn_test
150/221 Test #150: nc_test4_run_par_warn_test ................***Failed    2.20 sec

Testing MPI parallel I/O with various other mode flags...
sh: srun: command not found

*** Testing for HDF5 extra output
*** Testing create of parallel I/O file...ok.
*** Tests successful!
1d0
< sh: srun: command not found

This was running as a Slurm job in a container. The test calls mpiexec, and it assumes it has Slurm support, so it tries to use srun, which is not available in the container. It should not be a big deal, the test still works, and other tests using MPI print the same error. However, for this particular (and new) test, they redirect stderr and stdout to a file, and do a diff with a reference file. That causes the real failure here, because that srun error ends up in the output file... (see https://github.com/Unidata/netcdf-c/blob/v4.9.3/nc_test4/run_par_warn_test.sh.in#L17)

So I guess we should either:

patch this specific test, for instance by not writing stderr to the test output file
completely disable this test
unset the SLURM env vars for the tests, to make sure that they don't try to use srun (Clean up SLURM/Batchsystem environment before doing builds easybuild-framework#4434)
disable the slurm module using PRTE_MCA_plm=^slurm

boegel · 2026-03-10T18:47:49Z

@bedroge I would go with unset the SLURM env vars...

bedroge · 2026-03-10T22:13:24Z

@bedroge I would go with unset the SLURM env vars...

Thanks, done in 7be18a1.

bedroge · 2026-03-10T22:13:41Z

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER/pr25490"

boegelbot · 2026-03-10T22:20:08Z

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25490 EB_ARGS="--installpath /tmp/$USER/pr25490" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25490 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 10000

Test results coming soon (I hope)...

Details

- notification for comment with ID 4034801926 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

bedroge · 2026-03-10T23:55:28Z

Test report by @bedroge
SUCCESS
Build succeeded for 2 out of 2 (total: 1 hour 38 mins 37 secs) (2 easyconfigs in total)
omni33 - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, AMD EPYC 7763 64-Core Processor (zen3), Python 3.12.12
See https://gist.github.com/bedroge/b604ac0f4d3009f02ae5551c3b791745 for a full test report.

boegelbot · 2026-03-11T00:55:10Z

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (total: 2 hours 34 mins 43 secs) (5 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/a9ec6b0c7e4bb93527eec57505d04372 for a full test report.

boegel

lgtm

boegel · 2026-03-12T08:16:06Z

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (total: 5 hours 2 mins 13 secs) (5 easyconfigs in total)
node4213.shinx.os - Linux RHEL 9.6, x86_64, AMD EPYC 9654 96-Core Processor (zen4), Python 3.9.21
See https://gist.github.com/boegel/166c7792ada4bee97ffa78f9ed7084a0 for a full test report.

boegel · 2026-03-12T09:59:26Z

Going in, thanks @bedroge!

replace ENABLE_DAP_REMOTE_TESTS by NETCDF_ENABLE_DAP_REMOTE_TESTS

5dd2cf6

bedroge added the bug fix label Mar 3, 2026

github-actions Bot added 2025a issues & PRs related to 2025a common toolchains 2025b issues & PRs related to 2025b common toolchains change labels Mar 3, 2026

Thyre added this to the next release (5.2.2?) milestone Mar 3, 2026

Thyre removed the change label Mar 3, 2026

bedroge mentioned this pull request Mar 4, 2026

{2025.06}[2025a,2025b] netCDF 4.9.3 EESSI/software-layer#1432

Merged

add fix for tests trying to use srun

7be18a1

github-actions Bot added the change label Mar 10, 2026

bedroge changed the title ~~use NETCDF_ENABLE_DAP_REMOTE_TESTS instead of ENABLE_DAP_REMOTE_TESTS in netCDF 4.9.3 easyconfigs~~ use NETCDF_ENABLE_DAP_REMOTE_TESTS instead of ENABLE_DAP_REMOTE_TESTS and prevent use of srun in netCDF 4.9.3 easyconfigs Mar 10, 2026

bedroge added ready-to-review and removed change labels Mar 11, 2026

boegel approved these changes Mar 11, 2026

View reviewed changes

boegel merged commit 5af71d7 into easybuilders:develop Mar 12, 2026
6 checks passed

bedroge deleted the netcdf493_dap_remote_tests branch March 12, 2026 10:07

bedroge removed the ready-to-review label Mar 12, 2026

Conversation

bedroge commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedroge commented Mar 3, 2026

Uh oh!

boegelbot commented Mar 3, 2026

Uh oh!

Thyre commented Mar 4, 2026

Uh oh!

bedroge commented Mar 4, 2026

Uh oh!

bedroge commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boegel commented Mar 10, 2026

Uh oh!

bedroge commented Mar 10, 2026

Uh oh!

bedroge commented Mar 10, 2026

Uh oh!

boegelbot commented Mar 10, 2026

Uh oh!

bedroge commented Mar 10, 2026

Uh oh!

boegelbot commented Mar 11, 2026

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

boegel commented Mar 12, 2026

Uh oh!

boegel commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bedroge commented Mar 3, 2026 •

edited

Loading

bedroge commented Mar 4, 2026 •

edited

Loading