Skip to content

add --with-zlib configure argument in libxml easyconfigs#2555

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:libxml2_with_zlib
Feb 23, 2016
Merged

add --with-zlib configure argument in libxml easyconfigs#2555
boegel merged 1 commit intoeasybuilders:developfrom
boegel:libxml2_with_zlib

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 23, 2016

cfr. suggestion by @pescobar in #2551

@boegel boegel added this to the v2.7.0 milestone Feb 23, 2016
@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6529/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@pescobar
Copy link
Copy Markdown
Member

thanks for the quick fix @boegel :)

looks good to me but I would suggest a rebuild test because I am not sure if all the libxml2 versions have the --with-zlib option . I have only tested this with libxml2-2.9.3

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 23, 2016

Thanks for the review @pescobar.

The oldest libmlx2 version we have easyconfigs for supports it:

-bash-4.1$ cd libxml2-2.8.0
-bash-4.1$ ./configure --help | grep zlib
  --with-zlib[=DIR]       use libz in DIR

Test report on the way.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 23, 2016

Test report by @boegel
SUCCESS
Build succeeded for 46 out of 46 (46 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/0ecc79eac892195f99d2 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 23, 2016

boom!

Going in, thanks @pescobar!

boegel added a commit that referenced this pull request Feb 23, 2016
add --with-zlib configure argument in libxml easyconfigs
@boegel boegel merged commit c66c603 into easybuilders:develop Feb 23, 2016
@boegel boegel deleted the libxml2_with_zlib branch February 23, 2016 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants