Skip to content

add patch to support $TRITON_HOME In Triton 3.1#25557

Merged
Micket merged 2 commits intoeasybuilders:developfrom
Flamefire:20260313090854_new_pr_Triton310
Mar 16, 2026
Merged

add patch to support $TRITON_HOME In Triton 3.1#25557
Micket merged 2 commits intoeasybuilders:developfrom
Flamefire:20260313090854_new_pr_Triton310

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Mar 13, 2026 •
edited
Loading

(created using eb --new-pr)

In Triton 3.2 a new variable $TRITON_HOME was introduced which can be used to avoid writing to $HOME/.triton

In 3.1 this is missing and our PyTorch builds using this Triton version cause writes to the users HOME which is undesirable. The change is trivial so adding it here as a patch

@github-actions github-actions Bot added 2024a issues & PRs related to 2024a common toolchains change labels Mar 13, 2026
@Flamefire Flamefire mentioned this pull request Mar 13, 2026
Merged
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Mar 13, 2026

Test report by @Flamefire
FAILED
Build succeeded for 0 out of 1 (total: 27 mins 2 secs) (1 easyconfigs in total)
i8011 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7352 24-Core Processor (zen2), 8 x NVIDIA NVIDIA A100-SXM4-40GB, 580.65.06, Python 3.9.21
See https://gist.github.com/Flamefire/a8b11fbde5cdd9be5155346befc684ad for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Mar 16, 2026

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (total: 16 mins 28 secs) (1 easyconfigs in total)
i8029 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7352 24-Core Processor (zen2), 8 x NVIDIA NVIDIA A100-SXM4-40GB, 580.65.06, Python 3.9.21
See https://gist.github.com/Flamefire/1e0f317854c48d3e0f9a2d7056cdb6c6 for a full test report.

Micket
Micket approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the next release (5.2.2?) milestone Mar 16, 2026
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 16, 2026

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 16, 2026

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25557 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25557 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10029

Test results coming soon (I hope)...

Details

- notification for comment with ID 4067371587 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 16, 2026

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (total: 42 mins 49 secs) (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/049ea4b60495da2f854c604c235b85d0 for a full test report.

@Micket Micket merged commit 37cf440 into easybuilders:develop Mar 16, 2026
6 checks passed
@Flamefire Flamefire deleted the 20260313090854_new_pr_Triton310 branch March 17, 2026 09:01
@Flamefire Flamefire mentioned this pull request Mar 18, 2026
Merged
@boegel boegel changed the title Support $TRITON_HOME In Triton 3.1 add patch to support $TRITON_HOME In Triton 3.1 Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

2024a issues & PRs related to 2024a common toolchains change enhancement

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @Micket @boegelbot