Skip to content

remove PyTorch (and CUDA) dependency for CellRank 2.0.2, since they're not actually needed#25580

Merged
boegel merged 3 commits intoeasybuilders:developfrom
pavelToman:20260317163629_new_pr_CellRank202
Mar 25, 2026
Merged

remove PyTorch (and CUDA) dependency for CellRank 2.0.2, since they're not actually needed#25580
boegel merged 3 commits intoeasybuilders:developfrom
pavelToman:20260317163629_new_pr_CellRank202

Conversation

@pavelToman
Copy link
Copy Markdown
Collaborator

@pavelToman pavelToman commented Mar 17, 2026

(created using eb --new-pr)
It seems that CellRank has no PyTorch nor CUDA dependency - probably some mistake, when I was creating the easyconfig.

@pavelToman pavelToman changed the title Update CellRank - remove PyTorch and CUDA dependencies Update CellRank-2.0.2-foss-2023a - remove PyTorch and CUDA dependencies Mar 17, 2026
@pavelToman
Copy link
Copy Markdown
Collaborator Author

@boegelbot please test @ jsc-zen3-a100

@boegelbot
Copy link
Copy Markdown
Collaborator

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25580 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25580 --ntasks=8 --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10044

Test results coming soon (I hope)...

Details

- notification for comment with ID 4076010354 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (total: 1 hour 1 min 48 secs) (2 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 590.48.01, Python 3.9.25
See https://gist.github.com/boegelbot/40fb8aca50d4d8abca10669bb49efa9d for a full test report.

@pavelToman
Copy link
Copy Markdown
Collaborator Author

Test report by @pavelToman
SUCCESS
Build succeeded for 3 out of 3 (total: 1 hour 24 mins 12 secs) (2 easyconfigs in total)
node4005.donphan.os - Linux RHEL 9.6, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, 1 x NVIDIA NVIDIA A2, 580.95.05, Python 3.9.21
See https://gist.github.com/pavelToman/7e52e6297e9292276d83937734703de5 for a full test report.

@boegel boegel added this to the next release (5.2.2?) milestone Mar 24, 2026
@boegel boegel changed the title Update CellRank-2.0.2-foss-2023a - remove PyTorch and CUDA dependencies remove PyTorch (and CUDA) dependency for CellRank 2.0.2, since they're not actually needed Mar 24, 2026
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 24, 2026

Indeed, there's no sign of torch being required for CellRank 2.0.2, see also https://github.com/scverse/cellrank/blob/v2.0.2/pyproject.toml#L47, so good to merge...

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 24, 2026

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (total: 3 mins 46 secs) (1 easyconfigs in total)
node4211.shinx.os - Linux RHEL 9.6, x86_64, AMD EPYC 9654 96-Core Processor (zen4), Python 3.9.21
See https://gist.github.com/boegel/82f0d282b2d5e02d20a44ca4da3eeb92 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2026

Going in, thanks @pavelToman!

@boegel boegel merged commit 5a44a1c into easybuilders:develop Mar 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants