Skip to content

fix pcre config options. Required for future R lang releases#2561

Merged
boegel merged 1 commit intoeasybuilders:developfrom
pescobar:pcre-configure-fix
Feb 24, 2016
Merged

fix pcre config options. Required for future R lang releases#2561
boegel merged 1 commit intoeasybuilders:developfrom
pescobar:pcre-configure-fix

Conversation

@pescobar
Copy link
Copy Markdown
Member

No description provided.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6566/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

sources = [SOURCELOWER_TAR_GZ]

configopts = "--with-pic --disable-cpp --enable-utf8 --enable-unicode-properties"
configopts = "--with-pic --disable-cpp --enable-utf --enable-unicode-properties"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should enable both utf and utf8?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--enable-utf8 is not needed. this is the output of ./configure --help

  --enable-utf8           another name for --enable-utf. Kept only for
                          compatibility reasons

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok, great

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 24, 2016

Test report by @boegel
SUCCESS
Build succeeded for 12 out of 12 (12 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/f9c9af75e01e9b0bf113 for a full test report.

@pescobar
Copy link
Copy Markdown
Member Author

for the record...this fix is needed because when compiling R-devel version and loading the PCRE module in easybuild compiled without --enable-utf then you get this error:

checking if PCRE version >= 8.10, < 10.0 and has UTF-8 support... no
checking whether PCRE support suffices... configure: error: pcre >= 8.10 library and headers are required

when recompiling PCRE with the --enable-utf option this issue is fixed.

In previous R release PCRE was included in the R tarball so PCRE was not a required dependency in the R easyconfig but in coming R version PCRE has to be included as a dependency because R tarball no longer includes it

I did the tests with this R tarball: https://stat.ethz.ch/R/daily/R-devel_2016-02-23.tar.gz

@pescobar
Copy link
Copy Markdown
Member Author

after recompiling PCRE with --enable-utf --enable-unicode-properties ./configure works.

checking if PCRE version >= 8.10, < 10.0 and has UTF-8 support... yes
checking if PCRE version >= 8.32... yes
checking whether PCRE support suffices... yes

@boegel boegel added this to the v2.7.0 milestone Feb 24, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 24, 2016

This is good to go imho, thanks @pescobar!

boegel added a commit that referenced this pull request Feb 24, 2016
fix pcre config options. Required for future R lang releases
@boegel boegel merged commit 5a3a010 into easybuilders:develop Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants