Skip to content

{tools}[dummy/dummy] MLC v3.0#2577

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20160226125812_new_pr_MLC30
Feb 26, 2016
Merged

{tools}[dummy/dummy] MLC v3.0#2577
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20160226125812_new_pr_MLC30

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 26, 2016

(created using eb --new-pr)

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6601/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.7.0 milestone Feb 26, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/113a1fd96d78cabb4e87 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2016

@wpoely86: ...

sources = ['mlcv3.0.tgz']

sanity_check_paths = {
'files': ['Linux/mlc', 'Linux/mlc_avx512', 'mlc_license.txt', 'readme.pdf'],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want a license and readme in the sanity check?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, they're part of the tarball being unpacked... if they're not there, soemthing is wrong

and we do this in other places too, license and documentation are important part of an installation?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2016

Going in, thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Feb 26, 2016
@boegel boegel merged commit ac7ce3c into easybuilders:develop Feb 26, 2016
@boegel boegel deleted the 20160226125812_new_pr_MLC30 branch February 26, 2016 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants