Skip to content

{tools}[GCC/4.6.3] attr v2.4.47#2706

Merged
boegel merged 4 commits intoeasybuilders:developfrom
boegel:20160311162200_new_pr_attr2447
Mar 11, 2016
Merged

{tools}[GCC/4.6.3] attr v2.4.47#2706
boegel merged 4 commits intoeasybuilders:developfrom
boegel:20160311162200_new_pr_attr2447

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 11, 2016

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2074.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/8bb4fbc0f73a57326107 for a full test report.

@boegel boegel mentioned this pull request Mar 11, 2016
Merged
wpoely86
wpoely86 reviewed Mar 11, 2016
View reviewed changes
Comment thread easybuild/easyconfigs/a/attr/attr-2.4.47-GCC-4.6.3.eb
homepage = 'http://savannah.nongnu.org/projects/attr'
description = """Commands for Manipulating Filesystem Extended Attributes"""

toolchain = {'name': 'GCC', 'version': '4.6.3'}
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Mar 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old?

Copy link
Copy Markdown
Member Author

@boegel boegel Mar 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, needed to fix issue with old easyconfig, cfr. #2699 and easybuilders/easybuild-easyblocks#854

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 11, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7034/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2074.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/e2119d7cc123ac91b403 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2074.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/760d11264a81bfd904ff for a full test report.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 11, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7039/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.7.0 milestone Mar 11, 2016
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 11, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7040/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@besserox
Copy link
Copy Markdown
Contributor

besserox commented Mar 11, 2016

@boegel What about additional sanity checks on include/attr/libattr.h and include/attr/xattr.h ?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2016

@besserox: well, I'm checking for a non-empty include/attr directory...

I can extend that each of the files in there are present?

attributes.h  error_context.h  libattr.h  xattr.h

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2074.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/cee847387cdb870a8f59 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2016

@besserox: extended sanity check paths to check all 4 include files

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 11, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7042/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2016

Going in, thanks for the feedback @wpoely86 and @besserox!

boegel added a commit that referenced this pull request Mar 11, 2016
@boegel
Merge pull request #2706 from boegel/20160311162200_new_pr_attr2447
690ad8a 
{tools}[GCC/4.6.3] attr v2.4.47
@boegel boegel merged commit 690ad8a into easybuilders:develop Mar 11, 2016
@boegel boegel deleted the 20160311162200_new_pr_attr2447 branch March 11, 2016 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @hpcugentbot @besserox @wpoely86